Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow --inspect-brk option to be used with babel-node [6.x backport] #5795

Closed
wants to merge 19 commits into from
Closed

Allow --inspect-brk option to be used with babel-node [6.x backport] #5795

wants to merge 19 commits into from

Conversation

noinkling
Copy link
Contributor

Backport of #5785

MrSpider and others added 18 commits April 6, 2017 11:40
@MrSpider @hzoo
Fix replacing function declaration in export default (fixes #4468) (#…
fd3a2c2 
…5456)
@xtuc
Update transform-es2015-modules-commonjs doc #5588
d40cb31
@xtuc
Remove incorrect docs. #5580
149acc4
@xtuc
Improve example of babel-plugin-transform-es2015-arrow-functions #5573
2cb4d08
@xtuc
Update babel-generator's README #5517
e2c2d7d
@xtuc
Update coffescript/register reference link address #5475
e9bc213
@xtuc
document cache option for babel-register #5440
c1b3740
@xtuc
[doc] Fix: comments in usage w/ options #5400
982aba3
@xtuc
Improve options documentation for babel-plugin-transform-runtime #5401
ca435b6
@existentialism
Merge pull request #5613 from babel/backport-doc-changes
11b7db0 
Backport doc changes
@ssuman @loganfsmyth
Increase the code coverage for traverse evaluation (#5363)
412180e 
* When applied this commit will increase the code coverage for evaluation.js

* Fixing linting issues
@jridgewell @hzoo
Hoist toSequenceExpression's convert helper (#5693)
5f866f2 
* Hoist toSequenceExpression's convert helper

* Adds tests

* lint

* dev-depend on babel-generator
@existentialism @hzoo
Fix incorrect property ordering with obj rest spread on nested (#5750)
9a92933
@u9lyfish
Fix broken tables in README.md
58c6863
@jridgewell
Merge pull request #5755 from u9lyfish/patch-1
5b26184 
Fix broken tables in README.md
@hzoo
[skip ci]
51f3ab4
@peey @hzoo
Add a section on troubleshooting [skip ci] (#5788)
dcbb6c5 
* Add a section on troubleshooting [skip ci]

* Move troubleshooting section to be under the running tests section

* [skip ci]
@noinkling
Allow --inspect-brk option to be used with babel-node
20c2b89
@mention-bot
Copy link

@noinkling, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @neVERberleRfellerER and @danez to be potential reviewers.

@codecov
Copy link

codecov bot commented May 31, 2017 •
edited
Loading

Codecov Report

Merging #5795 into master will increase coverage by 0.31%.
The diff coverage is 95.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5795      +/-   ##
==========================================
+ Coverage   84.44%   84.76%   +0.31%     
==========================================
  Files         204      204              
  Lines        9605     9614       +9     
  Branches     2697     2703       +6     
==========================================
+ Hits         8111     8149      +38     
+ Misses       1007      981      -26     
+ Partials      487      484       -3
Impacted Files Coverage Δ
packages/babel-cli/src/babel-node.js 48.97% <0%> (-1.03%) ⬇️
packages/babel-traverse/src/path/replacement.js 73.45% <100%> (+0.23%) ⬆️
...l-plugin-transform-object-rest-spread/src/index.js 98.33% <100%> (+0.05%) ⬆️
packages/babel-types/src/converters.js 94.55% <97.43%> (+3.58%) ⬆️
packages/babel-traverse/src/path/context.js 85.34% <0%> (ø) ⬆️
packages/babel-traverse/src/visitors.js 86.66% <0%> (+0.95%) ⬆️
packages/babel-traverse/src/path/evaluation.js 81.53% <0%> (+12.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3570ba7...de863fa. Read the comment docs.

@jridgewell
Copy link
Member

This should be the master branch, right?

@existentialism
Copy link
Member

Derp, yep... good catch, let's retarget.

@existentialism existentialism changed the base branch from 6.x to master May 31, 2017 01:44
@existentialism existentialism changed the base branch from master to 6.x May 31, 2017 01:50
@existentialism
Copy link
Member

@noinkling didn't want to force push on to your 6.x branch, mind retargeting?

@noinkling noinkling changed the base branch from 6.x to master May 31, 2017 01:58
@noinkling noinkling changed the base branch from master to 6.x May 31, 2017 01:58
@noinkling
Copy link
Contributor Author

noinkling commented May 31, 2017 •
edited
Loading

Sorry my git fu isn't great, how would I go about that without opening a new PR?

I don't care what happens to that 6.x branch if it matters.

@noinkling
Copy link
Contributor Author

noinkling commented May 31, 2017 •
edited
Loading

I guess this is why you should always create a new branch for a PR, I'll try again 😄

@noinkling noinkling closed this May 31, 2017
@noinkling noinkling changed the base branch from 6.x to master May 31, 2017 02:10
@noinkling noinkling mentioned this pull request May 31, 2017
Merged
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

Assignees
No one assigned
Labels
6.x: backport outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@noinkling @mention-bot @jridgewell @existentialism @MrSpider @xtuc @ssuman @u9lyfish @hzoo @peey