Fix bug - undefined reference for export declaration #3629
Conversation
boopathi
commented
Aug 4, 2016
boopathi
commented
- (Fix https://phabricator.babeljs.io/T7534)
- Export declaration class/function/var ids now add the export declaration path as the referenced one.
+ (Fix https://phabricator.babeljs.io/T7534) + Export declaration class/function/var ids now add the export declaration path as the referenced one.
Current coverage is 88.61% (diff: 100%)@@ master #3629 diff @@
==========================================
Files 188 188
Lines 15486 15486
Methods 1838 1838
Messages 0 0
Branches 4122 4122
==========================================
Hits 13723 13723
Misses 1763 1763
Partials 0 0
|
|
Oh interesting - makes sense... wonder if we can add a simple test for this one? (Yeah I know there aren't many for traverse) Can merge and add as a todo later too |
hzoo
added
the
PR: Bug Fix 🐛
| let declar = node.declaration; | ||
| if (t.isClassDeclaration(declar) || t.isFunctionDeclaration(declar)) { | ||
| let id = declar.id; | ||
| if (!id) return; | ||
|
|
||
| let binding = scope.getBinding(id.name); | ||
| if (binding) binding.reference(); | ||
| if (binding) binding.reference(path); |
There was a problem hiding this comment.
I'm just not sure if it should be binding.path or path ... I guess it should be path, or both path and binding.path...
There was a problem hiding this comment.
Hmm, so path points to the "ExportDefaultDeclaration" and binding.path points to the delcaration of the export, the "ClassDeclaration"
sounds like path based on this and this?
unless it's supposed to be the path to the identifier so that would be path.get('declaration.id')?
Oh yeah it errors with
Unexpected ExportDefaultDeclaration. Expected an Identifier
at Mangler.renameNew (./babel-plugin-minify-mangle-names/lib/index.js:193:19)
if (!path.isIdentifier()) {
// if this occurs, then it is
// probably an upstream bug (in babel)
throw new Error("Unexpected " + path.node.type + ". Expected an Identifier");
}
so maybe path.get('declaration.id') for the first and path.get('declaration.declarations')[i] for the 2nd
lock
bot
added
the
outdated
