Handle logical assignment in super property transforms #14164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
magic-akari
commented
Jan 17, 2022
•
magic-akari
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #14163 |
| Patch: Bug Fix? | 👍 |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
| _superprop_getFoo = () => super.foo; | ||
|
|
||
| (function () { | ||
| _superprop_setFoo(_superprop_getFoo() ?? 4); |
There was a problem hiding this comment.
Logical expressions short-circuit, so this should become something like
_superprop_getFoo() ?? _superprop_setFoo(4);
JLHwung
added
PR: Bug Fix 🐛
JLHwung
approved these changes
Jan 17, 2022
| const value = assignmentPath.node.right; | ||
|
|
||
| assignmentPath.node.operator = "="; | ||
| const isLogicalAssignment = op === "||" || op === "&&" || op === "??"; |
There was a problem hiding this comment.
nit: @babel/types exports LOGICAL_OPERATORS so we don't have to hardcode them.
There was a problem hiding this comment.
Updated.
Type narrowing is hard.
JLHwung
approved these changes
Jan 17, 2022
Comment on lines
+402
to
+406
| type LogicalOp = Parameters<typeof logicalExpression>[0]; | ||
| type BinaryOp = Parameters<typeof binaryExpression>[0]; | ||
|
|
||
| function isLogicalOp(op: string): op is LogicalOp { | ||
| return LOGICAL_OPERATORS.includes(op); |
There was a problem hiding this comment.
If TS allows const and type with the same name, we could even export type LOGICAL_OPERATORS = "||" | "&&" | "??" from @babel/types.
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.