-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helpers): match Reflect.get
behaviour
#13862
fix(helpers): match Reflect.get
behaviour
#13862
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49729/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cbc533a:
|
To test this you can set |
f6010f1
to
cbc533a
Compare
Rebased on main, and added 2 tests that fail before the patch, pass after. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The first call to
babelHelpers.get
substitutestarget
for falsy 3rd argumentreceiver
. That is not correct for several reasons:The reimplementation should follow
Reflect.get
spec, i.e. only substitutetarget
whenreceiver
argument is missing, not when it's falsy or nullish.Regarding tests, I think I know how to devise a test for the falsy receiver issue, but I have no idea how to test the first-call stub behaviour.