-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass browserslistEnv
to resolveTargets
#13697
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48313/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b8b67ba:
|
...ages/babel-helper-compilation-targets/test/browserslist-extends/browserslist-extends.spec.js
Outdated
Show resolved
Hide resolved
62eb2f1
to
a84b13a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
a84b13a
to
b8b67ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I usually ask to not commit changes to .gitignore
since you can use .git/info/exclude
instead. However, since this also needs change in the Jest config and since that extension looks useful (I might use it!), it's ok this time.
browserslistEnv
to resolveTargets
In case of explicitly specifying browserslist query with
extends
keyword,browserslistEnv
option was not passed to browserslist itself leading to wrong resolved targets