Load .browserslistrc when using old @babel/core versions
#12934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolo-ribaudo
commented
Feb 28, 2021
nicolo-ribaudo
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #12880 |
| Patch: Bug Fix? | Yes |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
nicolo-ribaudo
added
PR: Bug Fix 🐛
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bed912f:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/43128/ |
JLHwung
approved these changes
Mar 1, 2021
hzoo
approved these changes
Mar 1, 2021
|
This patch update has broken my build wachunei/directUC#238 here is the error: https://github.com/wachunei/directUC/pull/238/checks?check_run_id=2012844416#step:7:14 🚨 /home/runner/work/directUC/directUC/src/img/icon_16.png: Invalid Version: undefined
at new SemVer (/home/runner/work/directUC/directUC/node_modules/@babel/preset-env/node_modules/semver/semver.js:314:11)
at compare (/home/runner/work/directUC/directUC/node_modules/@babel/preset-env/node_modules/semver/semver.js:647:10)
at lt (/home/runner/work/directUC/directUC/node_modules/@babel/preset-env/node_modules/semver/semver.js:688:10)
at /home/runner/work/directUC/directUC/node_modules/@babel/preset-env/lib/index.js:276:22
at Object.default (/home/runner/work/directUC/directUC/node_modules/@babel/helper-plugin-utils/lib/index.js:22:12)
at getEnvPlugins (/home/runner/work/directUC/directUC/node_modules/parcel-bundler/src/transforms/babel/env.js:62:34)
at getEnvConfig (/home/runner/work/directUC/directUC/node_modules/parcel-bundler/src/transforms/babel/env.js:12:25)
at async getBabelConfig (/home/runner/work/directUC/directUC/node_modules/parcel-bundler/src/transforms/babel/config.js:32:19)
at async babelTransform (/home/runner/work/directUC/directUC/node_modules/parcel-bundler/src/transforms/babel/transform.js:6:16)
at async JSAsset.pretransform (/home/runner/work/directUC/directUC/node_modules/parcel-bundler/src/assets/JSAsset.js:83:5) |
bemnlam
added a commit
to bemnlam/parcel
that referenced
this pull request
Mar 2, 2021
This change in babel babel/babel#12934 breaks Parcel if version doesn't pass into presetEnv(). By setting version as 7.13.0 presetEnv() will continue other checking, just like the logic before.
This was referenced Mar 5, 2021
Closed
Closed
Closed
This was referenced Mar 17, 2021
Closed
Merged
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.