Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add decimal parsing support #11640

Merged
merged 10 commits into from
Jul 29, 2020
Merged

Add decimal parsing support #11640

merged 10 commits into from
Jul 29, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented May 29, 2020 •
edited by gitpod-io bot
Loading

Q                       A
Fixed Issues? Closes tc39/proposal-decimal#18
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Added initial parsing support on Decimal Proposal, e.g. 0.3m.

AST spec

  • parser support
  • generator support
  • create @babel/syntax-decimal
  • add to @babel/standalone
  • babel parser typings

@JLHwung JLHwung mentioned this pull request May 29, 2020
Closed
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 29, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3c84908:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented May 29, 2020 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26230/

@JLHwung JLHwung added PR: New Feature 🚀 A type of pull request used for our changelog categories Spec: Decimal labels May 29, 2020
@JLHwung JLHwung marked this pull request as ready for review May 29, 2020 15:45
@nicolo-ribaudo nicolo-ribaudo added this to the 7.11.0 milestone May 31, 2020
@nicolo-ribaudo nicolo-ribaudo self-requested a review May 31, 2020 20:05
@JLHwung JLHwung changed the base branch from master to main June 19, 2020 13:29
@JLHwung JLHwung added the PR: Needs Review A pull request awaiting more approvals label Jun 24, 2020
@JLHwung JLHwung added PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release and removed PR: Needs Review A pull request awaiting more approvals labels Jul 27, 2020
@JLHwung JLHwung merged commit 059e912 into babel:main Jul 29, 2020
@JLHwung JLHwung deleted the decimal branch July 29, 2020 20:43
@fisker fisker mentioned this pull request Aug 2, 2020
Closed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 29, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@hzoo hzoo hzoo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release Spec: Decimal
Projects
None yet
Milestone
7.11.0
Development

Successfully merging this pull request may close these issues.

Babel PR for BigDecimal syntax: volunteers wanted
4 participants
@JLHwung @babel-bot @hzoo @nicolo-ribaudo