chore: map mobile browser data to their desktop version #10814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
the
PR: Internal 🏠
nicolo-ribaudo
previously approved these changes
Dec 4, 2019
nicolo-ribaudo
dismissed
their stale review
Does this depend on browserslist/browserslist#428?
|
@nicolo-ribaudo Actually it works like browserslist/browserslist#428 by replacing the caniuse mobile desktop agents by their desktop versions. Oh it does depend on that since we will throw on unknown browser versions. Now we have to skip |
existentialism
approved these changes
Dec 5, 2019
|
The upstream fix has been released |
|
@nicolo-ribaudo unskipping Therefore, I suggest we merge it as-is. |
JLHwung
commented
Dec 5, 2019
| @@ -120,7 +120,7 @@ describe("getTargets", () => { | |||
| it("does throws on unsupported versions", () => { | |||
| expect(() => { | |||
| getTargets({ | |||
| browsers: "node 15.0.0, chrome 1000", | |||
| browsers: "node 1000.0.0, chrome 1000", | |||
There was a problem hiding this comment.
Time flies: node 15 is scheduled at Oct. 2020.
nicolo-ribaudo
force-pushed
the
fix-build-module-data-script
branch
from
8a005fe to
551f2d9
Compare
nicolo-ribaudo
approved these changes
Jan 21, 2020
kaicataldo
approved these changes
Jan 22, 2020
nicolo-ribaudo
force-pushed
the
fix-build-module-data-script
branch
from
65fb3d6 to
9c34ab8
Compare
rajasekarm
pushed a commit
to rajasekarm/babel
that referenced
this pull request
Feb 17, 2020
* chore: map mobile browser data to their desktop version * chore: skip android until upstream support is resolved * Revert "chore: skip android until upstream support is resolved" This reverts commit 436e9af. * Update fixtures Co-authored-by: Nicolò Ribaudo <[email protected]>
This was referenced Feb 24, 2020
This was referenced Feb 26, 2020
This was referenced Mar 7, 2020
This was referenced Mar 25, 2020
This was referenced Apr 2, 2020
This was referenced Apr 9, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we map the ES Module support data for mobile browser to their desktop versions. caniuse now preserve only latest version for the mobile browser other than
iOS Safari. It fixes the issue that whencaniuse-dbis upgraded, theand_chrandand_ffwill be incorrectly bumped.