-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
throw a TypeError if identifier validation fails #10621
Conversation
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
I've had to depend on and import esutils
in a few projects because this was never exposed. Yay!
@jridgewell We do have plan to refactor it. In the near future babel-types will not depend on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This reverts commit c7d8b8a.
I noticed that
t.identifier(name)
accepts invalid identifiers, this PR fixes that bug. Thanks to @JLHwung for finding the reason so quickly!