Removes empty captures #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @zertosh ? Other people have been hit by this issue in the linked issue. I understand that you're rewriting the grammar anyway, but this PR should be easily reviewable, and fix a major issue (major in that it completely prevents the grammar from being used at all :(). |
|
+1 I've encountered this as well. See also: atom/first-mate#77 and microsoft/vscode-textmate#9 where others have encountered this too. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These rules are causing issues with both first-mate and vscode-textmate, because they match empty strings and can cause infinite loops. The trailing | are unnecessary and are not present in the other rules, so I just had to remove them altogether.