Skip to content
This repository has been archived by the owner on May 11, 2018. It is now read-only.

Add flow #269

Merged
merged 18 commits into from
May 15, 2017
Merged

Add flow #269

merged 18 commits into from
May 15, 2017

Conversation

yavorsky
Copy link
Member

Also replaced uglify with useSyntax like in #264 and will pull changes after use-syntax-option into 2.0 merge.

@codecov-io
Copy link

codecov-io commented Apr 11, 2017

Codecov Report

Merging #269 into 2.0 will decrease coverage by 0.35%.
The diff coverage is 98.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.0     #269      +/-   ##
==========================================
- Coverage   96.06%   95.71%   -0.36%     
==========================================
  Files           9        9              
  Lines         407      420      +13     
  Branches      129      128       -1     
==========================================
+ Hits          391      402      +11     
- Misses          4        5       +1     
- Partials       12       13       +1
Impacted Files Coverage Δ
src/targets-parser.js 94.23% <100%> (-2.14%) ⬇️
src/use-built-ins-entry-plugin.js 100% <100%> (ø) ⬆️
src/utils.js 100% <100%> (ø) ⬆️
src/normalize-options.js 100% <100%> (ø) ⬆️
src/index.js 97.67% <100%> (+0.08%) ⬆️
src/use-built-ins-plugin.js 93.7% <87.5%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c924f6...43f2236. Read the comment docs.

@yavorsky yavorsky requested a review from existentialism April 11, 2017 12:02
@yavorsky yavorsky changed the title [WIP] Add flow Add flow Apr 12, 2017
@existentialism
Copy link
Member

@yavorsky mind rebasing?

@yavorsky
Copy link
Member Author

@existentialism yeah, on it

@existentialism
Copy link
Member

existentialism commented May 5, 2017

@yavorsky hope you don't mind, wanted to get this landed so I resolved the conflicts.

Small tweaks:

  • Bumped flow to 0.45
  • Reverted renaming modules option to moduleType (we can do that separately, as we may want to discuss whether or not we want that breaking change, whether to preserve backwards compatibility, and consistency with other presets, etc)

Otherwise, your changes look awesome, mind giving this a review?

@yavorsky
Copy link
Member Author

yavorsky commented May 15, 2017

@existentialism Oh, thanks!
Yeah. I think it's ready to be merged. 🕺
Also, we could add scripts/test/*.js files in the future.

@existentialism existentialism merged commit 1e9cd73 into 2.0 May 15, 2017
@yavorsky yavorsky deleted the flow-2 branch May 15, 2017 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants