Skip to content
This repository has been archived by the owner on May 11, 2018. It is now read-only.

Add simple smoke-test #240

Merged
merged 1 commit into from
Mar 31, 2017
Merged

Add simple smoke-test #240

merged 1 commit into from
Mar 31, 2017

Conversation

existentialism
Copy link
Member

@existentialism existentialism commented Mar 31, 2017

Fixes #237.

Really simple, but it would have caught #235.

@existentialism existentialism changed the title Add simple require smoke-test Add simple smoke-test Mar 31, 2017
@codecov-io
Copy link

codecov-io commented Mar 31, 2017

Codecov Report

Merging #240 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #240   +/-   ##
======================================
  Coverage    92.7%   92.7%           
======================================
  Files           4       4           
  Lines         192     192           
  Branches       57      57           
======================================
  Hits          178     178           
  Misses          9       9           
  Partials        5       5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe74b77...8101857. Read the comment docs.

Copy link
Member

@yavorsky yavorsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should we add it to scripts in package.json?

@existentialism
Copy link
Member Author

@yavorsky I added it originally, but took it out thinking it was highly specialized for CI. I dunno? Can add it later.

@existentialism existentialism merged commit b2057c0 into master Mar 31, 2017
@existentialism existentialism deleted the smoke-test branch March 31, 2017 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants