This repository has been archived by the owner on May 11, 2018. It is now read-only.
Fix hasBeenWarned condition. #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzoo
reviewed
Feb 27, 2017
src/normalize-options.js
Outdated
| @@ -71,7 +69,7 @@ export const validateModulesOption = (modulesOpt = "commonjs") => { | |||
|
|
|||
| export default function normalizeOptions(opts) { | |||
| // TODO: remove whitelist in favor of include in next major | |||
| if (opts.whitelist && !hasBeenWarned) { | |||
| if (opts.whitelist) { | |||
| console.warn( | |||
There was a problem hiding this comment.
then we should add hasBeenWarned = true in the if block? otherwise it will warn multiple times?
There was a problem hiding this comment.
@hzoo yes! I thought it could be called once, but actually not. Updated!
yavorsky
changed the title
|
Should we add a test for this? |
|
oh yeah, always |
|
maybe bot should warn - if you change src and no test files changed 😼 |
|
Maybe pre-commit hook? You can't commit unless some tests were added 🙂 I'll cover it after lunch (UTC +2). |
|
Nah since I don't want new contributors to not make the pr if they don't have it, can tell them after? |
|
I was joking :) But the bot that shows changes coverage - great idea! |
|
And we do have codecov set up on babel already |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove check for static
hasBeenWarnedthat alwaysfalse.