Transformations before logs #128

yavorsky · 2017-01-09T17:25:40Z

Log transformations after excluded/included processing. Fixes debug option: using plugins/using polyfills should account for includes/excludes #127.
Prevent a second iteration by replacing filtration from 2 to 1 call:

before

items
  .filter((builtInName) => isPluginRequired(targets, pluginsList))
  .filter((plugin) => exclusions.indexOf(plugin) === -1)

now

  const filterBuiltIns = filterItem.bind(null, targets, exclusions, pluginsList)
  items.filter(filterBuiltIns)

hzoo · 2017-01-09T17:26:01Z

src/index.js

    if (useBuiltIns && polyfills.length) {
+      console.log("\nUsing polyfills:");


👍 noticed that too

hzoo · 2017-01-10T17:07:29Z

Would also be nice to set up a test for debug: true sometime

yavorsky added 3 commits January 9, 2017 19:12

Filter transformations before logs.

03de738

Check default plugins for exclusions.

d3453b1

Add semicolon.

8b5fc78

hzoo reviewed Jan 9, 2017

View reviewed changes

src/index.js

if (useBuiltIns && polyfills.length) {

console.log("\nUsing polyfills:");

Copy link

Member

hzoo Jan 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 noticed that too

existentialism approved these changes Jan 10, 2017

View reviewed changes

hzoo approved these changes Jan 10, 2017

View reviewed changes

hzoo added the i: bug label Jan 10, 2017

hzoo merged commit 028c4ea into babel:master Jan 10, 2017

existentialism mentioned this pull request Jan 10, 2017

Add tests for debug output #133

Closed

yavorsky mentioned this pull request Jan 27, 2017

Fixes #143. Log correct targets. #155

Merged

yavorsky deleted the transformations-before-logs branch August 14, 2017 12:25

hzoo mentioned this pull request Oct 5, 2017

Add tests for debug output babel/babel#6429

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transformations before logs #128

Transformations before logs #128

yavorsky commented Jan 9, 2017 •

edited

Loading

hzoo Jan 9, 2017

hzoo commented Jan 10, 2017

		if (useBuiltIns && polyfills.length) {
		console.log("\nUsing polyfills:");

Transformations before logs #128

Transformations before logs #128

Conversation

yavorsky commented Jan 9, 2017 • edited Loading

hzoo Jan 9, 2017

Choose a reason for hiding this comment

hzoo commented Jan 10, 2017

yavorsky commented Jan 9, 2017 •

edited

Loading