no node7 rules. node -> chrome version aliases miss gaps

[graingert]

Currently the version aliases are:

{
	"safari6": "phantom",
	"chrome44": "node4",
	"chrome50": "node6",
	"chrome51": "node65",
	"chrome54": "node7",
	"chrome30": "android44",
	"chrome37": "android50",
	"chrome39": "android51",
	"safari51": "ios6",
	"safari7": "ios7",
	"safari71_8": "ios8",
	"safari9": "ios9",
	"safari10": "ios10"
}

note that chrome53 and chrome52 are missing. This means that any rule, eg async-functions does not include those changes.

This is currently fine because all those changes are covered by flags

[hzoo]

you can make a pr if you'd like for those, otherwise will close then?

[graingert]

I'm just saying the alias algorithm is wrong

[hzoo]

It's wrong? I'm not clear on what you mean - do we need to make a pr to compat-table?

[hzoo]

Can you explain this again? I'm afraid I didn't understand the issue?

[graingert]

in compat table:

  function interpolateResults(res) {
    var browser, prevBrowser, result, prevResult, bid, prevBid;
    for (bid in rawBrowsers) {
      // For browsers that are essentially equal to other browsers,
      // copy over the results.
      browser = rawBrowsers[bid];
      if (browser.equals && res[bid] === undefined) {
        result = res[browser.equals];
        res[bid] = browser.ignore_flagged && result === 'flagged' ? false : result;
      // For each browser, check if the previous browser has the same
      // browser full name (e.g. Firefox) or family name (e.g. Chakra) as this one.
      } else if (prevBrowser &&
          (prevBrowser.full.replace(/,.+$/,'') === browser.full.replace(/,.+$/,'') ||
          (browser.family !== undefined && prevBrowser.family === browser.family))) {
        // For each test, check if the previous browser has a result
        // that this browser lacks.
        result     = res[bid];
        prevResult = res[prevBid];
        if (prevResult !== undefined && result === undefined) {
          res[bid] = prevResult;
        }
      }
      prevBrowser = browser;
      prevBid = bid;
    }

flattens all previous browsers and equal browsers flags onto the new browser.

your ./scripts/build-data.js only looks at the first browser after an equals, eg node7 should include all the changes of chrome54, chrome53, chrome52. Instead you only look at chrome54