chore: replace mkdirp by make-dir@2 #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existentialism
approved these changes
Mar 23, 2020
| @@ -4451,7 +4451,7 @@ mixin-deep@^1.2.0: | |||
| for-in "^1.0.2" | |||
| is-extendable "^1.0.1" | |||
|
|
|||
| mkdirp@^0.5.0, mkdirp@^0.5.1, mkdirp@^0.5.3: | |||
| mkdirp@^0.5.0, mkdirp@^0.5.1: | |||
There was a problem hiding this comment.
Wouldn't this still trigger the deprecation warning anyway?
There was a problem hiding this comment.
mkdirp is now depended only by our devDependencies or peerDependencies.
$ yarn why mkdirp
=> Found "[email protected]"
info Reasons this module exists
- "@babel#cli" depends on it
- Hoisted from "@babel#cli#mkdirp"
- Hoisted from "eslint#mkdirp"
- Hoisted from "webpack#mkdirp"
- Hoisted from "nyc#spawn-wrap#mkdirp"
- Hoisted from "@babel#cli#output-file-sync#mkdirp"
- Hoisted from "ava#unique-temp-dir#mkdirp"
- Hoisted from "webpack#terser-webpack-plugin#cacache#mkdirp"
- Hoisted from "chokidar#fsevents#node-pre-gyp#mkdirp"
- Hoisted from "chokidar#fsevents#node-pre-gyp#tar#mkdirp"
- Hoisted from "webpack#terser-webpack-plugin#cacache#move-concurrently#mkdirp"
- Hoisted from "eslint#file-entry-cache#flat-cache#write#mkdirp"
- Hoisted from "webpack#terser-webpack-plugin#cacache#move-concurrently#copy-concurrently#mkdirp"
Update: @babel/cli has switched to make-dir in babel/babel#8622 so this PR is also aligning to what we have done on @babel/cli.
Not a blocker for this PR, but this shouldn't be a problem since we resolved the security vulnerability in #834 |
nicolo-ribaudo
approved these changes
Mar 23, 2020
hiroppy
approved these changes
Mar 23, 2020
Closed
|
@nicolo-ribaudo can this please be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
Behavior is unchanged.
What is the new behavior?
Replace
mkdirpbymake-dir@2so thatbabel-loaderdoes not depend onminimistanymore. (mkdirpbundled a cli but we are not using it anyway)babel-loadershould not print a frustrating deprecated message frommkdirpDoes this PR introduce a breaking change?
If this PR contains a breaking change, please describe the following...
Fixes Mkdirp < 1 deprecated #833