Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

Fix: Convert RegExpLieteral value to RegExp object (fixes #477) #478

Merged
merged 1 commit into from
May 30, 2017
Merged

Fix: Convert RegExpLieteral value to RegExp object (fixes #477) #478

merged 1 commit into from
May 30, 2017

Conversation

soda0289
Copy link
Contributor

The only way I could get the tests to fail was to check the constructor name of both objects. I tried to match them for every object but many times they do not match.

kentcdodds
kentcdodds reviewed May 29, 2017
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me.

babylon-to-espree/toAST.js
try {
node.value = new RegExp(node.pattern, node.flags);
} catch (err) {
node.value = null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give a scenario in tests that handles when the value is null? Also, perhaps we should have it default to {} as it was before? Otherwise this could be a breaking change right?

Copy link
Contributor Author

@soda0289 soda0289 May 29, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A scenario where value is null is when the flags u and y are not supported. I have tests cases for these and it will produce null when run in node v4 and v5.

I'm not sure this is a breaking change since the output is was producing is a bug and did not match what espree, or esprima produce. The reason the test pass is it only compared the typeof, which were both objects, but not from the same class. We could set the default to {} but that would not match the ESTree spec for RegExp Literal nodes.
https://github.com/estree/estree/blob/master/es5.md#regexpliteral

This does fix an issue with eslint eslint/eslint#8655 and setting the default to {} might cause other rule failures.

The estree plugin for babylon does produce the correct output so if this were to be considered a breaking change we could wait till that is implemented in this parser.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've convinced me. Thanks 😄

@kentcdodds kentcdodds merged commit 54ed517 into babel:master May 30, 2017
wcjohnson added a commit to wcjohnson/lightscript-eslint that referenced this pull request Oct 25, 2017
@wcjohnson
3.0
30af98b 
commit 3dfd2ff
Author: William C. Johnson <[email protected]>
Date:   Wed Oct 25 00:32:52 2017 -0400

    @oigroup/[email protected]

commit 2d842e6
Author: William C. Johnson <[email protected]>
Date:   Wed Oct 25 00:10:30 2017 -0400

    @oigroup/[email protected]

commit ae1363a
Author: William C. Johnson <[email protected]>
Date:   Tue Oct 24 23:54:50 2017 -0400

    @oigroup/[email protected]

commit f74e487
Author: William C. Johnson <[email protected]>
Date:   Sun Oct 22 15:18:19 2017 -0400

    @oigroup/[email protected]

commit 8117e94
Author: William C. Johnson <[email protected]>
Date:   Fri Oct 20 21:02:16 2017 -0400

    @oigroup/[email protected]

commit 046d90b
Author: William C. Johnson <[email protected]>
Date:   Thu Oct 19 16:51:39 2017 -0400

    @oigroup/[email protected]

commit 6cfb623
Author: William C. Johnson <[email protected]>
Date:   Thu Oct 19 16:48:27 2017 -0400

    Disable no-else-return rule

    Doc updates also

commit 8fb9ef8
Author: William C. Johnson <[email protected]>
Date:   Thu Oct 12 22:31:36 2017 -0400

    Disable `no-unexpected-multiline` in eslint 4

commit 3dabeae
Author: William C. Johnson <[email protected]>
Date:   Thu Oct 12 21:08:36 2017 -0400

    @oigroup/[email protected]

commit ce3ba57
Author: William C. Johnson <[email protected]>
Date:   Thu Oct 12 20:18:51 2017 -0400

    @oigroup/[email protected]

commit d7945d6
Author: William C. Johnson <[email protected]>
Date:   Thu Oct 12 20:06:28 2017 -0400

    Packaging updates

commit fb7c378
Author: William C. Johnson <[email protected]>
Date:   Thu Oct 12 20:03:24 2017 -0400

    Update deps

commit 97cae1f
Author: William C. Johnson <[email protected]>
Date:   Thu Oct 12 18:11:10 2017 -0400

    Post-merge fixups

commit 1c30620
Merge: 5721d25 54ed517
Author: William C. Johnson <[email protected]>
Date:   Thu Oct 12 18:05:41 2017 -0400

    Merge remote-tracking branch 'babel-eslint/7.x' into prerelease/3.0.0

    # Conflicts:
    #	README.md
    #	babylon-to-espree/toAST.js
    #	index.js
    #	package.json
    #	test/non-regression.js
    #	yarn.lock

commit 5721d25
Author: William C. Johnson <[email protected]>
Date:   Thu Oct 12 17:20:09 2017 -0400

    Remove separate `pickBy` dep

commit 6bd6f19
Author: William C. Johnson <[email protected]>
Date:   Wed Oct 11 21:38:51 2017 -0400

    @oigroup/[email protected]

commit fe34c6c
Author: William C. Johnson <[email protected]>
Date:   Wed Oct 11 01:24:05 2017 -0400

    @oigroup/[email protected]

commit 52dadaa
Author: William C. Johnson <[email protected]>
Date:   Wed Oct 11 01:15:42 2017 -0400

    Monkey-patch getFirstTokens

commit 4197163
Author: William C. Johnson <[email protected]>
Date:   Sun Oct 8 21:31:37 2017 -0400

    Linter uses tooling API

    wcjohnson/lightscript#30
    wcjohnson/lightscript#31

commit ab96233
Author: William C. Johnson <[email protected]>
Date:   Sun Oct 8 16:35:32 2017 -0400

    @oigroup/[email protected]

commit ea1ddf6
Author: William C. Johnson <[email protected]>
Date:   Sun Oct 8 16:34:20 2017 -0400

    Catch up to plugin

commit 8c36f6c
Author: William C. Johnson <[email protected]>
Date:   Fri Oct 6 17:49:53 2017 -0400

    @oigroup/[email protected]

commit 3f9444e
Author: William C. Johnson <[email protected]>
Date:   Tue Oct 3 15:26:06 2017 -0400

    @oigroup/[email protected]

commit f1ea213
Author: William C. Johnson <[email protected]>
Date:   Mon Oct 2 21:36:21 2017 -0400

    @oigroup/[email protected]

commit 8dcd15b
Author: William C. Johnson <[email protected]>
Date:   Mon Oct 2 21:35:09 2017 -0400

    Patch linter for 3.0 alpha changes

commit f35f5bb
Author: William C. Johnson <[email protected]>
Date:   Sat Sep 30 22:09:47 2017 -0400

    @oigroup/[email protected]

commit 9b3c535
Author: William C. Johnson <[email protected]>
Date:   Thu Sep 28 21:27:31 2017 -0400

    @oigroup/[email protected]

commit 7e0882e
Author: William C. Johnson <[email protected]>
Date:   Thu Sep 28 21:15:46 2017 -0400

    Update comprehension syntax

commit deb1718
Author: William C. Johnson <[email protected]>
Date:   Wed Sep 27 22:17:27 2017 -0400

    @oigroup/[email protected]

commit 57160c5
Author: William C. Johnson <[email protected]>
Date:   Wed Sep 27 22:06:26 2017 -0400

    3.0 defaults update

commit 1b5e466
Author: William C. Johnson <[email protected]>
Date:   Wed Sep 27 22:06:20 2017 -0400

    Quieted unmapped node message

commit 54ed517
Author: Reyad Attiyat <[email protected]>
Date:   Mon May 29 20:41:14 2017 -0500

    Fix: Convert RegExpLieteral value to RegExp object (fixes babel#477) (babel#478)

commit 94bb5a1
Author: Sebastian McKenzie <[email protected]>
Date:   Fri Apr 21 22:14:19 2017 +0100

    7.2.3

commit dfaff04
Author: Andres Suarez <[email protected]>
Date:   Fri Apr 21 11:48:52 2017 -0400

    Fix flow type spread handling (babel#465)

commit f59d200
Author: Henry Zhu <[email protected]>
Date:   Wed Apr 12 12:07:05 2017 -0400

    7.2.2

commit 8622009
Author: Vitor Balocco <[email protected]>
Date:   Wed Apr 12 17:59:23 2017 +0200

    Fix: use eslint-scope instead of escope if present (babel#461)

commit 0f611b8
Author: Andres Suarez <[email protected]>
Date:   Thu Mar 30 13:49:51 2017 -0400

    Separate finding peer deps from monkeypatching (babel#460)

commit 1201e12
Author: Andres Suarez <[email protected]>
Date:   Sat Mar 25 19:36:10 2017 -0400

    Remove unused .gitmodules (babel#457)

commit a750684
Author: Andres Suarez <[email protected]>
Date:   Sat Mar 25 19:32:05 2017 -0400

    Use dedent for unpadding (babel#456)

commit cdb92fe
Merge: 21dac73 ec14787
Author: Henry Zhu <[email protected]>
Date:   Sat Mar 25 19:15:23 2017 -0400

    Merge pull request babel#455 from babel/babylon-to-espree-tidy

    Tidy up babylon-to-espree

commit ec14787
Author: Andres Suarez <[email protected]>
Date:   Sat Mar 25 18:03:17 2017 -0400

    Enable strict mode in all of babylon-to-espree

commit 6c5beec
Author: Andres Suarez <[email protected]>
Date:   Sat Mar 25 18:01:13 2017 -0400

    Move ast convert steps to babylon-to-espree

commit d2ce789
Author: Andres Suarez <[email protected]>
Date:   Sat Mar 25 17:42:51 2017 -0400

    Use for-loop for template literal conversion

commit 539af05
Author: Andres Suarez <[email protected]>
Date:   Sat Mar 25 17:36:20 2017 -0400

    Only iterate over tokens once

commit 06c3a31
Author: Andres Suarez <[email protected]>
Date:   Sat Mar 25 17:28:01 2017 -0400

    Inline fixDirectives and use for-loop

commit 5d32ad0
Author: Andres Suarez <[email protected]>
Date:   Sat Mar 25 17:07:41 2017 -0400

    Consolidate versions of "convertComments"

commit 2541fc9
Author: Andres Suarez <[email protected]>
Date:   Sat Mar 25 00:18:57 2017 -0400

    toAst pass "source" in state instead of keeping in scope

commit 21dac73
Author: Andres Suarez <[email protected]>
Date:   Thu Mar 23 15:46:48 2017 -0400

    Add type parameter scope tests (babel#454)

commit 3cda62e
Author: Henry Zhu <[email protected]>
Date:   Thu Mar 23 14:03:23 2017 -0400

    7.2.1

commit 5626de1
Author: Andres Suarez <[email protected]>
Date:   Thu Mar 23 14:02:24 2017 -0400

    Remove left over eslint 2 estraverse code (babel#452)

    This was missed in babel#361

commit b5fb53b
Author: Andres Suarez <[email protected]>
Date:   Thu Mar 23 12:49:19 2017 -0400

    Fix type param and interface declaration scoping (babel#449)

commit f1cee0f
Author: Andres Suarez <[email protected]>
Date:   Wed Mar 22 22:35:31 2017 -0400

    Remove lodash dependency (babel#450)

commit eb05812
Author: Andres Suarez <[email protected]>
Date:   Wed Mar 22 22:34:13 2017 -0400

    Format non-regression errors for legibility (babel#451)

commit 7972a05
Author: Luís Couto <[email protected]>
Date:   Tue Mar 21 00:11:30 2017 +0000

    Update README.md with codeFrame option (babel#448)

commit 4db4db5
Author: Henry Zhu <[email protected]>
Date:   Mon Mar 20 17:53:26 2017 -0400

    7.2.0

commit 4499412
Author: wtgtybhertgeghgtwtg <[email protected]>
Date:   Mon Mar 20 14:50:09 2017 -0700

    Use `lodash` instead of `lodash.pickby`. (babel#435)

commit a2c3b30
Author: Alex Rattray <[email protected]>
Date:   Mon Mar 20 14:46:07 2017 -0700

    [flow] Process polymorphic type bounds on functions (babel#444)

commit 515adef
Author: Luís Couto <[email protected]>
Date:   Mon Mar 20 21:45:11 2017 +0000

    Add option to disable code frame. (babel#446)

    * Add option to disable code hightlight.

    * Rename codeHighlight with codeFrame

    * Add codeFrame tests

    * Remove colors from test assertions

commit ce66e73
Merge: bdeb86f b49ab20
Author: Henry Zhu <[email protected]>
Date:   Mon Mar 20 11:44:33 2017 -0400

    Merge pull request babel#447 from kaicataldo/clean-up-eslint

    Chore: Clean up and upgrades

commit b49ab20
Author: Kai Cataldo <[email protected]>
Date:   Mon Mar 20 10:33:14 2017 -0400

    Updates ESLint version/remove unnecessary config

commit 702d6b8
Author: Kai Cataldo <[email protected]>
Date:   Mon Mar 20 10:27:28 2017 -0400

    Remove broken ESLint tests

commit 6b4c4ca
Author: Kai Cataldo <[email protected]>
Date:   Sat Mar 11 22:15:47 2017 -0500

    Upgrade outdated dependencies
wcjohnson added a commit to wcjohnson/lightscript-eslint that referenced this pull request Sep 20, 2018
@wcjohnson
feat: Begin update to Babel 7 (WIP)
3d8a957 
commit 6aa8b6f
Author: Henry Zhu <[email protected]>
Date:   Mon Aug 27 18:09:21 2018 -0400

    9.0.0

commit c7ee9ae
Author: Brian Ng <[email protected]>
Date:   Mon Aug 27 17:04:26 2018 -0500

    Bump to [email protected] 🎉 (babel#676)

commit 3ece549
Author: Ed Morley <[email protected]>
Date:   Thu Aug 23 06:23:06 2018 +0100

    Docs: Make the default parserOptions more explicit (babel#673)

    In particular, previously the `.eslintrc` example implied that the default value for `codeFrame` was `false`, when in fact it is `true`:
    https://github.com/babel/babel-eslint/blob/v9.0.0-beta.3/lib/parse.js#L14

commit 0b36951
Author: Alexandre Borela <[email protected]>
Date:   Thu Aug 23 02:21:45 2018 -0300

    Add logical assignment plugin (babel#674)

    Fix babel#672

commit 5856ff5
Author: Brian Ng <[email protected]>
Date:   Tue Aug 21 15:18:02 2018 -0500

    Bump some devDeps

commit 45938d9
Author: Leo Yin <[email protected]>
Date:   Wed Aug 22 04:00:17 2018 +0800

    build(deps): upgrade @babel/* to 7.0.0-rc.2 (babel#668)

commit bc97875
Author: Henry Zhu <[email protected]>
Date:   Thu Jul 12 09:50:58 2018 -0400

    9.0.0-beta.3

commit 74c5d62
Author: Henry Zhu <[email protected]>
Date:   Thu Jul 12 09:50:30 2018 -0400

    update lock

commit 6a45632
Author: Mark Tse <[email protected]>
Date:   Thu Jul 12 09:49:43 2018 -0400

    chore - fixing eslint-scope to a safe version; resolves babel#656. (babel#657)

commit e0119e0
Author: Brian Ng <[email protected]>
Date:   Fri Jul 6 11:24:45 2018 -0500

    9.0.0-beta.2

commit 198964b
Merge: 8948d83 9b06e1f
Author: Rubén Norte <[email protected]>
Date:   Fri Jul 6 17:20:52 2018 +0100

    Merge pull request babel#645 from rubennorte/support-new-flow-syntax-in-scope-analysis

    Support new flow syntax in scope analysis

commit 9b06e1f
Author: Rubén Norte <[email protected]>
Date:   Fri Jul 6 11:33:37 2018 +0100

    Added failing test for variables used in type parameters

commit 8948d83
Author: Rubén Norte <[email protected]>
Date:   Fri Jul 6 14:50:59 2018 +0100

    Upgrade Babel to v7.0.0-beta.52 (babel#650)

    * Upgrade Babel to v7.0.0-beta.52

    * Fixed failing test

commit 4882b29
Author: Brian Ng <[email protected]>
Date:   Fri Jun 29 08:37:18 2018 -0500

    9.0.0-beta.1

commit 15e8d6f
Author: Rubén Norte <[email protected]>
Date:   Fri Jun 29 14:26:43 2018 +0100

    Breaking: Upgraded Babel to 7.0.0-beta.51 (babel#642)

    * Upgraded Babel to 7.0.0-beta.51, with changes to decorators

    * Removed support for Node 4 and added it for Node 10

    * nit: fix typo [skip ci]

commit e865104
Author: Brian Ng <[email protected]>
Date:   Sat Jun 23 08:20:40 2018 -0500

    8.2.5

commit 10a402c
Author: Brian Ng <[email protected]>
Date:   Sat Jun 23 08:20:08 2018 -0500

    Revert bump to babel 51 (babel#640)

commit 2bd8508
Author: Brian Ng <[email protected]>
Date:   Fri Jun 22 13:39:23 2018 -0500

    8.2.4

commit 5881648
Author: Brian Ng <[email protected]>
Date:   Fri Jun 22 11:12:54 2018 -0500

    Add test for template string with object with template string inside (babel#639)

    Closes babel#538.
    Fixes babel#537.

    Now that babel#610 has landed, I wanted to make sure this case was covered.

commit 476426a
Author: Brian Ng <[email protected]>
Date:   Fri Jun 22 11:03:15 2018 -0500

    Support OptionalMemberExpression with scope too (babel#634)

commit 92874d4
Author: Brian Ng <[email protected]>
Date:   Fri Jun 15 16:39:58 2018 -0500

    Drop node4 in travis

commit d2ac299
Author: Brian Ng <[email protected]>
Date:   Mon Jun 11 08:47:15 2018 -0500

    Bump Babel deps

commit e63962d
Author: Cristian Pallarés <[email protected]>
Date:   Wed Jun 6 00:18:13 2018 +0200

    refactor: rename babylon to @babel/parser

commit 873f02f
Author: Brian Ng <[email protected]>
Date:   Mon Jun 18 16:46:31 2018 -0500

    Fix converting template types to handle nested templates (babel#610)

    Fixes babel#603 (and the fixture from babel#609 works).

    Reworks our code that converts the format of Babylon template tokens to be a bit more robust, especially with things like nested templates with arrows.

    (Adapted the logic from https://github.com/eslint/espree/blob/master/lib/token-translator.js)

commit 74a3207
Author: Rubén Norte <[email protected]>
Date:   Fri Jun 15 15:42:05 2018 +0100

    Fix token types for experimental operators (babel#632)

    * Added failing tests

    * Recognized nullish coalescing, optional chaining and pipeline operators as Punctuator tokens

commit e802577
Author: Rubén Norte <[email protected]>
Date:   Fri Jun 15 15:31:43 2018 +0100

    Add support for the optional chaining operator (babel#630)

commit ebc46e1
Author: jmurretxactly <[email protected]>
Date:   Tue May 8 05:52:59 2018 -0600

    don't require unpad per test fixture, fixes babel#572 (babel#618)

commit 9641e4b
Author: Ankur Oberoi <[email protected]>
Date:   Fri Apr 13 09:26:41 2018 -0700

    updates readme for latest eslint & babel-eslint (babel#607) [skip ci]

commit aaeb46b
Author: Henry Zhu <[email protected]>
Date:   Fri Apr 13 11:25:03 2018 -0400

    8.2.3

commit afc3c87
Author: Henry Zhu <[email protected]>
Date:   Fri Apr 13 11:23:59 2018 -0400

    lock to beta.44

commit 92202be
Author: Bary Levi <[email protected]>
Date:   Fri Apr 13 18:23:03 2018 +0300

    Save babel beta packages as exact versions (babel#606) [skip ci]

commit 9a6d663
Author: Daniel Tschinder <[email protected]>
Date:   Tue Feb 20 11:57:07 2018 +0100

    8.2.2

commit 51afa9e
Author: Daniel Tschinder <[email protected]>
Date:   Tue Feb 20 11:56:40 2018 +0100

    Allow newer versions of babel

commit 7928722
Author: Daniel Tschinder <[email protected]>
Date:   Tue Feb 20 11:54:09 2018 +0100

    Update dependencies

commit f958995
Author: Daniel Tschinder <[email protected]>
Date:   Tue Feb 20 11:49:19 2018 +0100

    chore(package): update lint-staged to version 6.1.1 (babel#592)

    Closes babel#539

commit 29b12ab
Author: Brian Ng <[email protected]>
Date:   Thu Feb 15 21:39:42 2018 -0600

    Bump deps (babel#591)

commit 236adb8
Author: Toru Nagashima <[email protected]>
Date:   Wed Jan 17 15:10:55 2018 +0900

    Fix: wrong token type of ! and ~ (fixes babel#576) (babel#577)

commit bf27f60
Author: Henry Zhu <[email protected]>
Date:   Mon Jan 8 19:15:40 2018 -0500

    8.2.1

commit d96ce55
Author: Henry Zhu <[email protected]>
Date:   Mon Jan 8 19:15:22 2018 -0500

    fix export change (babel#571)

commit ef27670
Author: Kai Cataldo <[email protected]>
Date:   Mon Jan 8 18:06:57 2018 -0500

    8.2.0

commit eba5920
Author: Henry Zhu <[email protected]>
Date:   Mon Jan 8 17:46:57 2018 -0500

    Add other parser plugins, update yarn.lock (babel#569)

commit e201fb4
Author: Kai Cataldo <[email protected]>
Date:   Mon Jan 8 17:45:24 2018 -0500

    Make 2018 the default ecmaVersion for rules relying on parserOptions (babel#556)

commit 1dedd1b
Author: jony89 <[email protected]>
Date:   Tue Jan 9 00:40:11 2018 +0200

    update babel packages (babel#565)

    * update babel packages

    There is some critical bug fixes in version babylon#7.0.0-beta.33 regard `async` - `await` syntax which is needed pretty immediately :)

    * remove test 42 (test for import type *)

    `import type *` is invalid, since the namespace can't be a type

commit 36bf8b4
Author: Toru Nagashima <[email protected]>
Date:   Tue Dec 26 10:59:19 2017 +0900

    8.1.2

commit 5aaf0e1
Author: Toru Nagashima <[email protected]>
Date:   Tue Dec 26 10:50:13 2017 +0900

    Fix: add Literal type to visitorKeys (babel#562)

    * Fix: add Literal type to visitorKeys
    * Fix: use ./visitor-keys

commit bf9092a
Author: Toru Nagashima <[email protected]>
Date:   Tue Dec 26 10:49:36 2017 +0900

    Fix: ignore eval (fixes babel#560) (babel#561)

commit d84b236
Author: Toru Nagashima <[email protected]>
Date:   Mon Dec 25 15:57:19 2017 +0900

    8.1.1

commit e4bed5a
Author: Teddy Katz <[email protected]>
Date:   Mon Dec 25 01:52:36 2017 -0500

    Fix: Prevent parseForESLint() behavior from changing after parse() is called (fixes babel#558)(babel#559)

    * Prevent parseForESLint() behavior from changing after parse() is called

    (fixes babel#558, fixes eslint/eslint#9767)

    * Avoid using the enhanced referencer after monkeypatching

    * Chore: add test for babel#558

    * Pass correct scope analyzer options

    * fix escope patch and improve tests

    * remove process.exit(1)

commit 893a5e3
Author: Teddy Katz <[email protected]>
Date:   Sun Dec 24 02:02:44 2017 -0500

    8.1.0

commit bba9d00
Author: Teddy Katz <[email protected]>
Date:   Sun Dec 24 02:00:29 2017 -0500

    Re-add parseNoPatch function (accidentally removed) (babel#557)

commit dbc6546
Author: Toru Nagashima <[email protected]>
Date:   Sun Dec 24 15:42:17 2017 +0900

    Use new scopeManager/visitorKeys APIs (babel#542)

    (fixes eslint/eslint#9762)

commit 1f220c2
Author: Logan Smyth <[email protected]>
Date:   Fri Dec 1 10:06:40 2017 -0800

    8.0.3

commit cf5ab03
Author: Logan Smyth <[email protected]>
Date:   Fri Dec 1 10:06:24 2017 -0800

    Fix mocha command path.

commit 0609da8
Author: Logan Smyth <[email protected]>
Date:   Fri Dec 1 10:05:34 2017 -0800

    Lock down dependency versions.

commit a0fbd50
Author: Henry Zhu <[email protected]>
Date:   Mon Nov 6 15:00:41 2017 -0500

    8.0.2

commit 2004b91
Author: Henry Zhu <[email protected]>
Date:   Mon Nov 6 14:57:56 2017 -0500

    require correct deps

commit fa56d21
Author: Henry Zhu <[email protected]>
Date:   Mon Nov 6 12:51:19 2017 -0500

    Always use unpad (babel#535)

commit 295091d
Author: Henry Zhu <[email protected]>
Date:   Mon Nov 6 12:47:47 2017 -0500

    Allow ^ version for babel dependencies (babel#534)

commit d3b8519
Author: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
Date:   Mon Nov 6 12:25:35 2017 -0500

    fix(package): update babylon to version 7.0.0-beta.31 (babel#533)

commit 54ab4ac
Author: Henry Zhu <[email protected]>
Date:   Tue Sep 26 16:18:43 2017 -0400

    8.0.1

commit c1a7882
Author: Clement Hoang <[email protected]>
Date:   Tue Oct 31 11:50:35 2017 -0700

    Update README.md support (babel#531) [skip ci]

    #linting channel is now archived in babel slack.

commit 51100c9
Author: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
Date:   Wed Oct 11 14:14:29 2017 +0200

    chore(package): update mocha to version 4.0.0 (babel#524)

commit 5742b71
Author: Jordan Gensler <[email protected]>
Date:   Tue Sep 26 13:17:44 2017 -0700

    Adding optionalCatchBinding to plugins. (babel#521)

commit 905887c
Author: Henry Zhu <[email protected]>
Date:   Tue Sep 12 09:44:23 2017 -0400

    8.0.0

commit 49493e4
Author: Henry Zhu <[email protected]>
Date:   Tue Sep 12 09:42:30 2017 -0400

    update to beta.0

commit 42d0c5b
Author: Daniel Tschinder <[email protected]>
Date:   Wed Aug 2 14:37:01 2017 +0200

    Remove already fixed workaround (babel#508)

commit 25bd208
Author: Henry Zhu <[email protected]>
Date:   Wed Jul 26 16:19:29 2017 -0400

    8.0.0-alpha.17

commit 1468905
Author: Henry Zhu <[email protected]>
Date:   Wed Jul 26 16:18:45 2017 -0400

    alpha.17

commit 57c133e
Author: Henry Zhu <[email protected]>
Date:   Thu Jul 13 13:01:31 2017 -0400

    8.0.0-alpha.15

commit 1e41162
Author: Henry Zhu <[email protected]>
Date:   Thu Jul 13 12:58:45 2017 -0400

    update (babel#504)

commit c31b577
Author: Evan Brodie <[email protected]>
Date:   Sun Jul 9 21:03:59 2017 -0400

    Readme update usage section (babel#501) [skip ci]

    * Updates README: Consolidates versioning table

    Basically a revert of 52b4a13. It is easier to read a single table instead of two locations in the README for the version compatabilities between ESLint and babel-eslint

    * Updates README: Add yarn command for installation

    * [skip ci]

commit c2626f9
Author: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
Date:   Sun Jun 25 08:30:29 2017 -0700

    Update eslint to the latest version 🚀 (babel#500)

    * chore(package): update eslint to version 4.1.0

    * escope -> eslint-scope

    * Fix linting

commit 3c6b2de
Author: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
Date:   Thu Jun 22 13:18:47 2017 -0700

    chore(package): update husky to version 0.14.0 (babel#498)

commit e052d5a
Author: Kevin Mårtensson <[email protected]>
Date:   Tue Jun 20 23:49:46 2017 +0200

    Update install instructions to use latest stable release (babel#497) [skip ci]

commit 8e3e088
Author: Henry Zhu <[email protected]>
Date:   Sun Jun 18 18:33:40 2017 -0400

    8.0.0-alpha.13

commit f757e22
Merge: 37f9242 5736be6
Author: Henry Zhu <[email protected]>
Date:   Sun Jun 18 18:30:59 2017 -0400

    Merge pull request babel#493 from danez/regression-test

    Test for babylon regression

commit 5736be6
Author: Daniel Tschinder <[email protected]>
Date:   Sun Jun 18 23:12:08 2017 +0200

    Update babylon

commit 37f9242
Author: Brian Ng <[email protected]>
Date:   Sat Jun 17 14:14:42 2017 -0500

    Add Prettier (babel#491)

commit d0c3223
Author: Daniel Tschinder <[email protected]>
Date:   Sat Jun 17 21:12:07 2017 +0200

    Test for babylon regression

commit 945f00a
Author: Henry Zhu <[email protected]>
Date:   Fri Jun 16 16:56:32 2017 -0400

    8.0.0-alpha.12

commit 39b4a6a
Author: Daniel Tschinder <[email protected]>
Date:   Thu Jun 15 23:03:02 2017 +0200

    Use babylon estree and ranges (babel#489)

commit 1aedb95
Author: Mark Banner <[email protected]>
Date:   Thu Jun 8 17:23:08 2017 +0100

    Fix: allow options to be optional when monkey patching escope.analyze (fixes babel#470). (babel#484)

commit a8003c0
Author: Reyad Attiyat <[email protected]>
Date:   Tue Jun 6 20:38:49 2017 -0500

    Use Node 8 and drop Node 5 from travis (babel#483)

    * Use Node 8 and drop Node 5 from travis

    * switch the order [skip ci]

commit c66ec51
Author: Reyad Attiyat <[email protected]>
Date:   Tue Jun 6 20:37:57 2017 -0500

    Update to Babylon 7 (fixes babel#481) (babel#482)

    * Update to Babylon 7 (fixes babel#481)

    * Pin dependencies to alpha version

    * fix deprecation, add other plugins

    * oops

    * Update index.js

    * Add tests for private class properties with rules no-undef no-unused-vars

commit 54ed517
Author: Reyad Attiyat <[email protected]>
Date:   Mon May 29 20:41:14 2017 -0500

    Fix: Convert RegExpLieteral value to RegExp object (fixes babel#477) (babel#478)

commit 94bb5a1
Author: Sebastian McKenzie <[email protected]>
Date:   Fri Apr 21 22:14:19 2017 +0100

    7.2.3

commit dfaff04
Author: Andres Suarez <[email protected]>
Date:   Fri Apr 21 11:48:52 2017 -0400

    Fix flow type spread handling (babel#465)

commit f59d200
Author: Henry Zhu <[email protected]>
Date:   Wed Apr 12 12:07:05 2017 -0400

    7.2.2

commit 8622009
Author: Vitor Balocco <[email protected]>
Date:   Wed Apr 12 17:59:23 2017 +0200

    Fix: use eslint-scope instead of escope if present (babel#461)

commit 0f611b8
Author: Andres Suarez <[email protected]>
Date:   Thu Mar 30 13:49:51 2017 -0400

    Separate finding peer deps from monkeypatching (babel#460)

commit 1201e12
Author: Andres Suarez <[email protected]>
Date:   Sat Mar 25 19:36:10 2017 -0400

    Remove unused .gitmodules (babel#457)

commit a750684
Author: Andres Suarez <[email protected]>
Date:   Sat Mar 25 19:32:05 2017 -0400

    Use dedent for unpadding (babel#456)

commit cdb92fe
Merge: 21dac73 ec14787
Author: Henry Zhu <[email protected]>
Date:   Sat Mar 25 19:15:23 2017 -0400

    Merge pull request babel#455 from babel/babylon-to-espree-tidy

    Tidy up babylon-to-espree

commit ec14787
Author: Andres Suarez <[email protected]>
Date:   Sat Mar 25 18:03:17 2017 -0400

    Enable strict mode in all of babylon-to-espree

commit 6c5beec
Author: Andres Suarez <[email protected]>
Date:   Sat Mar 25 18:01:13 2017 -0400

    Move ast convert steps to babylon-to-espree

commit d2ce789
Author: Andres Suarez <[email protected]>
Date:   Sat Mar 25 17:42:51 2017 -0400

    Use for-loop for template literal conversion

commit 539af05
Author: Andres Suarez <[email protected]>
Date:   Sat Mar 25 17:36:20 2017 -0400

    Only iterate over tokens once

commit 06c3a31
Author: Andres Suarez <[email protected]>
Date:   Sat Mar 25 17:28:01 2017 -0400

    Inline fixDirectives and use for-loop

commit 5d32ad0
Author: Andres Suarez <[email protected]>
Date:   Sat Mar 25 17:07:41 2017 -0400

    Consolidate versions of "convertComments"

commit 2541fc9
Author: Andres Suarez <[email protected]>
Date:   Sat Mar 25 00:18:57 2017 -0400

    toAst pass "source" in state instead of keeping in scope

commit 21dac73
Author: Andres Suarez <[email protected]>
Date:   Thu Mar 23 15:46:48 2017 -0400

    Add type parameter scope tests (babel#454)

commit 3cda62e
Author: Henry Zhu <[email protected]>
Date:   Thu Mar 23 14:03:23 2017 -0400

    7.2.1

commit 5626de1
Author: Andres Suarez <[email protected]>
Date:   Thu Mar 23 14:02:24 2017 -0400

    Remove left over eslint 2 estraverse code (babel#452)

    This was missed in babel#361

commit b5fb53b
Author: Andres Suarez <[email protected]>
Date:   Thu Mar 23 12:49:19 2017 -0400

    Fix type param and interface declaration scoping (babel#449)

commit f1cee0f
Author: Andres Suarez <[email protected]>
Date:   Wed Mar 22 22:35:31 2017 -0400

    Remove lodash dependency (babel#450)

commit eb05812
Author: Andres Suarez <[email protected]>
Date:   Wed Mar 22 22:34:13 2017 -0400

    Format non-regression errors for legibility (babel#451)

commit 7972a05
Author: Luís Couto <[email protected]>
Date:   Tue Mar 21 00:11:30 2017 +0000

    Update README.md with codeFrame option (babel#448)

commit 4db4db5
Author: Henry Zhu <[email protected]>
Date:   Mon Mar 20 17:53:26 2017 -0400

    7.2.0

commit 4499412
Author: wtgtybhertgeghgtwtg <[email protected]>
Date:   Mon Mar 20 14:50:09 2017 -0700

    Use `lodash` instead of `lodash.pickby`. (babel#435)

commit a2c3b30
Author: Alex Rattray <[email protected]>
Date:   Mon Mar 20 14:46:07 2017 -0700

    [flow] Process polymorphic type bounds on functions (babel#444)

commit 515adef
Author: Luís Couto <[email protected]>
Date:   Mon Mar 20 21:45:11 2017 +0000

    Add option to disable code frame. (babel#446)

    * Add option to disable code hightlight.

    * Rename codeHighlight with codeFrame

    * Add codeFrame tests

    * Remove colors from test assertions

commit ce66e73
Merge: bdeb86f b49ab20
Author: Henry Zhu <[email protected]>
Date:   Mon Mar 20 11:44:33 2017 -0400

    Merge pull request babel#447 from kaicataldo/clean-up-eslint

    Chore: Clean up and upgrades

commit b49ab20
Author: Kai Cataldo <[email protected]>
Date:   Mon Mar 20 10:33:14 2017 -0400

    Updates ESLint version/remove unnecessary config

commit 702d6b8
Author: Kai Cataldo <[email protected]>
Date:   Mon Mar 20 10:27:28 2017 -0400

    Remove broken ESLint tests

commit 6b4c4ca
Author: Kai Cataldo <[email protected]>
Date:   Sat Mar 11 22:15:47 2017 -0500

    Upgrade outdated dependencies
nicolo-ribaudo pushed a commit to babel/babel that referenced this pull request Nov 14, 2019
@soda0289
Fix: Convert RegExpLieteral value to RegExp object (fixes babel/babel…
cb2eb3a 
…-eslint#477) (babel/babel-eslint#478)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kentcdodds kentcdodds kentcdodds left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soda0289 @kentcdodds