Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

try catch estraverse-fb since eslint removed it in 2.3.0, temp skip b… #269

Merged
merged 1 commit into from
Mar 7, 2016

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Mar 7, 2016

…roken tests until we come up with a solution

Ref eslint/eslint#5476

babel-eslint monkey patches the visitorKeys of eslint for things like flow, jsx, experimental syntax (async, decorators, etc) but in ESLint 2.3.0 certain things were changed/removed.

Mostly that estraverse-fb was removed, eslint/eslint#5443 so we can just check for that

eslint/eslint#5478, eslint/eslint#4640 should help

…roken tests until we come up with a solution
hzoo added a commit that referenced this pull request Mar 7, 2016
try catch estraverse-fb since eslint removed it in 2.3.0, temp skip b…
@hzoo hzoo merged commit d2f90c7 into master Mar 7, 2016
@tupton
Copy link

tupton commented Mar 7, 2016

Is there any info on when this will be released? Would it be in a 5.0.x release or would we have to update to a 6.0 beta to get this fix?

@hzoo
Copy link
Member Author

hzoo commented Mar 7, 2016

This actually doesn't fix the probelm since the visitorkeys themselves aren't overridable in ESLint 2.3.0.

I did release a 6.0.0-beta.2 with this fix but it's better to pin to ESLint 2.2.x since there are other issues

@tupton
Copy link

tupton commented Mar 7, 2016

Thanks for the update.

Unfortunately, I'm using gulp-eslint, which probably doesn't want to pin to 2.2.x just for babel-eslint. The other "workaround" involves installing estraverse-fb explicitly, which I don't think has any other side-effects and seems to be getting the job done for now.

I'll keep an eye on those other eslint issues you mentioned above, too. Thanks again for the great work.

@hzoo
Copy link
Member Author

hzoo commented Mar 7, 2016

If it's working for you then maybe I can do a 5.0.1 with this - but I saw eslint/eslint#5494 and others (internal rules erroring as a result), so that's why I'm recommending pinning if possible.

@tupton
Copy link

tupton commented Mar 7, 2016

Ah, good point; I didn't see those other issues. I'll see if there's a better way to pin to 2.2.x. Thanks!

nicolo-ribaudo pushed a commit to babel/babel that referenced this pull request Nov 14, 2019
try catch estraverse-fb since eslint removed it in 2.3.0, temp skip b…
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants