Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neil dep add exits with code 0 on both failure and success #185

Closed
joakimen opened this issue Jul 8, 2023 · 1 comment
Closed

neil dep add exits with code 0 on both failure and success #185

joakimen opened this issue Jul 8, 2023 · 1 comment

Comments

@joakimen
Copy link

joakimen commented Jul 8, 2023

When neil dep add fails to add a dependency, it still exits with code 0.

# bash

$ cat deps.edn
{}

$ neil dep add "com.cognitect.aws/s3"; echo $?
0

$ cat deps.edn
{:deps {com.cognitect.aws/s3 {:mvn/version "848.2.1400.0"}}}

$ neil dep add "some-fake-dep"; echo $?
0

$ cat deps.edn
{:deps {com.cognitect.aws/s3 {:mvn/version "848.2.1400.0"}}}

Discussion: https://clojurians.slack.com/archives/C03KCV7TM6F/p1688836219372089

@borkdude
Copy link
Contributor

borkdude commented Jul 8, 2023

ok, I think printing a warning and then exiting with 1 would be ok

borkdude added a commit that referenced this issue Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants