Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting older Clojure versions #60

Closed
lread opened this issue Aug 12, 2024 · 2 comments · Fixed by #65
Closed

Consider supporting older Clojure versions #60

lread opened this issue Aug 12, 2024 · 2 comments · Fixed by #65

Comments

@lread
Copy link
Contributor

lread commented Aug 12, 2024

Perceived Problem

Babashka http-client relies on relatively recent Clojure fns:

Added in 1.11:

  • random-uuid

Added in 1.10

  • ex-cause
  • ex-message

This can make it less attractive as a dependency for libraries that would like to support less recent versions of Clojure. In my case this is Etaoin, which supports Clojure 1.9 and above.

Proposal

  • Replace the above newer fns with Clojure 1.9 compatible code (changes are minor).
  • Decide the minimum version of Clojure http-client wants to support (is 1.9 good?) and add test coverage (including on CI) for supported versions.

Next Steps

Happy to do this work if you are interested in this change.

@lread lread changed the title Consider support older Clojure version Consider supporting older Clojure versions Aug 12, 2024
@borkdude
Copy link
Contributor

Roughly 5 years ago I supported 1.9 and 1.10. Now 1.11 came out and it's almost 1.12 time.

Perhaps we can move the lower range to 1.10? Supporting the last two CLJ versions seems reasonable?

@lread
Copy link
Contributor Author

lread commented Aug 12, 2024

That seems reasonable to me. I can bump min version of Clojure for Etaoin to 1.10 as well.

lread added a commit to lread/http-client that referenced this issue Aug 12, 2024
borkdude pushed a commit that referenced this issue Aug 12, 2024
* Ensure support for Clojure 1.10 and above

Closes #60

* review feedback: move `test-clj` task code to file
lread added a commit to lread/http-client that referenced this issue Aug 12, 2024
Inconsequential, but ugly to leave in.

Amendment for babashka#60
@lread lread mentioned this issue Aug 12, 2024
4 tasks
borkdude pushed a commit that referenced this issue Aug 12, 2024
Inconsequential, but ugly to leave in.

Amendment for #60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants