Add force flag to delete-tree

[jlesquembre]

Closes #119

Please answer the following questions and leave the below in as part of your PR.

• This PR corresponds to an issue with a clear problem statement.

• This PR contains a test to prevent against future regressions

• I have updated the CHANGELOG.md file with a description of the addressed issue.

[borkdude]

The posix stuff only works on linux/mac, perhaps there is another way which is more OS-agnostic.
Also, no need to set the file permission when the file already has the right permission, perhaps?

[jlesquembre]

The windows part, sure, I have to fix it, any tips on how to test it without a windows computer?

Also, no need to set the file permission when the file already has the right permission, perhaps?

If the directory already have the right permissions (OWNER_WRITE and OWNER_EXECUTE) it doesn't change the permissions, or am I missing something?

[borkdude]

you're right

[borkdude]

Maybe File.setWriteable etc will suffice on Windows?

[jlesquembre]

Maybe File.setWriteable etc will suffice on Windows?

Looks like that :-) :

https://github.com/jlesquembre/fs/actions/runs/7268334832

[borkdude]

• Would there be any benefit of not changing the file permission on windows if the file is already writable? Is there a situation where this might throw an exception where the delete would have happened successfully, without first changing file permissions?
• Why not unify the code for windows and linux?

[jlesquembre]

Would there be any benefit of not changing the file permission on windows if the file is already writable?

I don't think so, File.setWriteable seems idempotent

Is there a situation where this might throw an exception where the delete would have happened successfully, without first changing file permissions?

The only case where we touch the permissions, and a delete would have happened successfully is on windows if a file is already writable. We call .setWriteable again, but it doesn't seem to make any difference.

Why not unify the code for windows and linux?

I think mean here, right? https://github.com/jlesquembre/fs/blob/0468ac76bef9f054400de9da5030203c2351c15a/src/babashka/fs.cljc#L583-L584

The issue is that I don't want to touch the permissions if not necessary (with the exception of already writable files on windows, since it makes sense to me to just enforce that is writable and avoid calling .canWrite).

But the rules are different on posix vs windows:

• posix:
  • Read-only files can be deleted
  • Files can be deleted only if the parent directory has the "rwx" permissions
• windows:
  • Read-only files cannot be deleted
  • Parent directory permissions don't affect the delete operation of the child file.

I wrote some tests on my fork to test those assumptions, I can add it to the PR if it makes sense:

jlesquembre@c4d4ccd

https://github.com/jlesquembre/fs/actions/runs/7281870406

[borkdude]

OK, let's add those tests and I'll merge

[borkdude]

Btw, this issue might also be relevant to the above:

borkdude/deps.clj#120 (comment)

[jlesquembre]

I added the tests, and a comment point out that the implementation is based on those assumptions.

[borkdude]

Thanks!