Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cider-doc doesn't work? #26

Closed
j-cr opened this issue Aug 13, 2020 · 7 comments · Fixed by clojure-emacs/cider#2889
Closed

cider-doc doesn't work? #26

j-cr opened this issue Aug 13, 2020 · 7 comments · Fixed by clojure-emacs/cider#2889

Comments

@j-cr
Copy link

j-cr commented Aug 13, 2020

M-x cider-doc str RET
cider-fallback-eval:info: Wrong type argument: char-or-string-p, nil

M-x cider-version RET
CIDER 0.26.0 (Nesebar)
@j-cr
Copy link
Author

j-cr commented Aug 13, 2020

$ bb --version
babashka v0.1.3

@borkdude
Copy link
Contributor

I'm getting this with CIDER 0.25.0snapshot:

Screenshot 2020-08-13 at 22 04 03

@borkdude
Copy link
Contributor

Can confirm that this is broken with CIDER 0.27.0snapshot. cc @bbatsov

@bbatsov
Copy link

bbatsov commented Aug 13, 2020

cider-fallback-eval:info: Wrong type argument: char-or-string-p, nil

I'll take a look tomorrow. Might be a good idea to implement the new lookup op, though.

@j-cr
Copy link
Author

j-cr commented Aug 13, 2020

seems like this might be related:
clojure-emacs/cider@4fd24b1

cider-fallback-eval:info -> (format cider-info-form var) ->

  (do
    (require 'clojure.java.io)
    (require 'clojure.walk)

    (if-let [var (resolve 'str)]
      (let [info (meta var)]
        (-> info
            (update :ns str)
            (update :name str)
            (update :file (comp str clojure.java.io/resource))
            (cond-> (:macro m) (update :macro str))
            (cond-> (:special-form m) (update :special-form str))
            (assoc :arglists-str (str (:arglists info)))
            (clojure.walk/stringify-keys)))))

->

clojure.lang.ExceptionInfo: Could not resolve symbol: m [at line 11, column 27]

Edit: yup, that fixes the issue; it should be (:macro info), right?

j-cr added a commit to j-cr/cider that referenced this issue Aug 13, 2020
@bbatsov
Copy link

bbatsov commented Aug 13, 2020

Yeah, exactly. Seems like I pasted some code from Orchard and forgot to adjust it. Sorry about that!

bbatsov pushed a commit to clojure-emacs/cider that referenced this issue Aug 13, 2020
@j-cr
Copy link
Author

j-cr commented Aug 13, 2020

(fixed in master)

@j-cr j-cr closed this as completed Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants