Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove completion feature from enhancd #191

Merged
merged 3 commits into from
Apr 1, 2023
Merged

Conversation

babarot
Copy link
Owner

@babarot babarot commented Mar 31, 2023

WHAT

Remove completion feature from enhancd to solve #172

WHY

I've added this feature #90 to follow zsh-interactive-cd style completion in enhancd but currently I'm facing these problems:

  • sometimes it looks to make bugs native cd completion #172
  • it's difficult to maintain these codes because completion feature is complex shell script

Now both plugins enhacd and zsh-interactive-cd can coexist in the same environment (I've tried it out). So those who get troubles by deleting this feature can use this plugin to cover this change.

@github-actions github-actions bot added area/bash Catch all for changes in bash files area/zsh Catch all for changes in zsh files labels Mar 31, 2023
@babarot babarot mentioned this pull request Mar 31, 2023
@babarot
Copy link
Owner Author

babarot commented Mar 31, 2023

Test:

Just enter cd <tab>

Screenshot 2023-03-31 at 20 01 51

After installed https://github.com/changyuheng/zsh-interactive-cd and then, enter cd <tab>

Screenshot 2023-03-31 at 20 01 28

YAML I used for testing is here:

github:
- name: b4b4r07/enhancd
  owner: b4b4r07
  repo: enhancd
  branch: babarot/remove-completion
  plugin:
    sources:
    - init.sh
- name: changyuheng/zsh-interactive-cd
  owner: changyuheng
  repo: zsh-interactive-cd
  plugin:
    sources:
    - '*.zsh'
  depends-on:
  - zsh

@babarot babarot marked this pull request as ready for review March 31, 2023 12:39
@github-actions github-actions bot added the area/fish Catch all for changes in fish files label Mar 31, 2023
@babarot babarot merged commit 1b5c8b8 into master Apr 1, 2023
@babarot babarot deleted the babarot/remove-completion branch April 1, 2023 12:00
@github-actions github-actions bot mentioned this pull request Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bash Catch all for changes in bash files area/fish Catch all for changes in fish files area/zsh Catch all for changes in zsh files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant