-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --dry-run option to launchpad start #69
Conversation
… sample web application with tests for port and logging
… move example to correct package etc. This doesn't yet resolve what to do about #run:withArguments: - that conversation still needs bottoming out.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-candidate #69 +/- ##
===================================================
Coverage 99.78% 99.79%
===================================================
Files 58 62 +4
Lines 3751 3870 +119
===================================================
+ Hits 3743 3862 +119
Misses 8 8 ☔ View full report in Codecov by Sentry. |
source/Launchpad-Commands-Tests/LaunchpadCommandLineHandlerTest.class.st
Show resolved
Hide resolved
source/Launchpad-Configuration-Pharo-Extensions/Boolean.extension.st
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a bit hard to review as there are lots of format changes from symbol to string - but I like the dry-run tests, and I can see there is an option to get at config symbolically.
Based on #64 made by @macta