Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IAsyncDisposable to TestServiceProvider #292

Merged
merged 1 commit into from
Dec 19, 2020

Conversation

egil
Copy link
Member

@egil egil commented Dec 19, 2020

Pull request description

PR meta checklist

  • Pull request is targeting at DEV branch.
  • Pull request is linked to all related issues, if any.
  • I have read the CONTRIBUTING.md document.

Content checklist

  • My code follows the code style of this project and AspNetCore coding guidelines.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have updated the appropriate sub section in the CHANGELOG.md.
  • I have added, updated or removed tests to according to my changes.
    • All tests passed.

@egil egil self-assigned this Dec 19, 2020
@egil egil linked an issue Dec 19, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 19, 2020

Codecov Report

Merging #292 (6f72e88) into dev (51d6b81) will increase coverage by 0.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #292      +/-   ##
==========================================
+ Coverage   82.69%   82.71%   +0.01%     
==========================================
  Files         126      126              
  Lines        3710     3714       +4     
  Branches      481      482       +1     
==========================================
+ Hits         3068     3072       +4     
  Misses        493      493              
  Partials      149      149              
Impacted Files Coverage Δ
src/bunit.core/TestServiceProvider.cs 93.22% <60.00%> (-3.15%) ⬇️
...it.core/Extensions/WaitForHelpers/WaitForHelper.cs 90.47% <0.00%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51d6b81...6f72e88. Read the comment docs.

@egil egil merged commit cd17f88 into dev Dec 19, 2020
@egil egil deleted the feature/249-async-dispose-services branch December 19, 2020 18:03
egil added a commit that referenced this pull request Dec 23, 2020
…hrough a cascading parameter of Task<AuthenticationState>

* Switched from using FakeIdentity and FakePrincipal to using built in types

* Updated changelog

* Code cleanup

* Added IAsyncDisposable to TestServiceProvider (#292)

* Update main.yml

* Updated SourceFileFinder dependency version

* workflow updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support services that implement IAsyncDisposable
1 participant