Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider whether InvokeAsync should move from IRenderedFragmentBase to IRenderedComponentBase #156

Closed
egil opened this issue Jun 22, 2020 · 0 comments
Closed

Consider whether InvokeAsync should move from IRenderedFragmentBase to IRenderedComponentBase #156

egil opened this issue Jun 22, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed input needed When an issue requires input or suggestions

Comments

@egil
Copy link
Member

egil commented Jun 22, 2020

InvokeAsync added in #82 might not make sense on IRenderedFragment, since there is no way to access the component instance through it.

It should probably be moved to the IRenderedFragmentBase type instead to make the API cleaner.

Remember to update the triggers-renders docs page.
@egil egil added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed input needed When an issue requires input or suggestions labels Jun 22, 2020
egil added a commit that referenced this issue Jun 26, 2020
@egil
Moved InvokeAsync from IRenderedFragmentBase to IRenderedComponentBase.
99a97c5 
Closes #156
@egil egil closed this as completed Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed input needed When an issue requires input or suggestions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@egil