Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thai doesn't read its control letters #30

Open
boomwooq opened this issue May 9, 2024 · 7 comments
Open

Thai doesn't read its control letters #30

boomwooq opened this issue May 9, 2024 · 7 comments

Comments

@boomwooq
Copy link

boomwooq commented May 9, 2024

I think, it's no longer read Thai script
CleanShot 2024-05-09 at 20 24 36@2x

@boomwooq boomwooq changed the title Thai doesn't read the control letter Thai doesn't read its control letters May 9, 2024
@Mark2Mark
Copy link
Collaborator

Indeed. Thanks for reporting. Someone must have broken something in recent Glyphs updates.
This plugin and its code is incredibly old and utilised lots of hacks back then. When I find the time I will need to properly clean up.

Hope I can fix this very issue soon. Sorry for that!

@schriftgestalt
Copy link
Collaborator

Can you point me to the code where it should read the control letters?

@Mark2Mark
Copy link
Collaborator

about here:

gCat = self.kenringStrings[inputGlyphScript][category]

the customKenringStrings are defined in kernKit.py

"thai": {
	"Letter": {
		"Other": {
			"Left": "/thoThahan-thai/thoThahan-thai/doDek-thai/thoThahan-thai",
			"Right": "/thoThahan-thai/doDek-thai/doDek-thai/noNu-thai",
		},
		"Spacing": {
			"Left": "/khoKhwai-thai/khoKhwai-thai/doDek-thai/khoKhwai-thai",
			"Right": "/khoKhwai-thai/doDek-thai/doDek-thai/khoKhwai-thai",
		},
	},
},

@schriftgestalt
Copy link
Collaborator

glyphs.subCategory in not "Other" any more, it is just None.

schriftgestalt added a commit to schriftgestalt/Kernkraft that referenced this issue May 21, 2024
@schriftgestalt
Copy link
Collaborator

I send a PR but didn’t test it.

@Mark2Mark
Copy link
Collaborator

Thanks! I will test later today ⏱️

@boomwooq
Copy link
Author

boomwooq commented Sep 17, 2024

@schriftgestalt Thank you! I did the test, works now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants