Add SSL support to transport layer (8.x) #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...channel; split Netty message handler into two classes; add utility methods to EventBusNettyUtil
...synchronization issues
- Update subclasses and references - Remove "send" method from BaseEvent that returns a Promise
...in MessageFactory
...separate package
Most of the operations lock a branch or repository target only for a short time interval eg. during a commit operation, but for some authoring tasks we allow clients to issue lock requests remotely. These locks should be released if the client disconnects and does not clean up on its own.
- Use NioSocketChannel instead of LocalChannel - Extract SnowOwlConfiguration to a local variable
After 15 seconds have passed without writing anything to the channel, an empty object is written to reset the "write idle" timer on the local side, and the "read idle" timer on the remote. After 30 seconds of no read activity, the corresponding channel is closed.
feature/SO-4987_netty_eventbus_8x Conflicts: cis/com.b2international.snowowl.snomed.cis.product/.launch/snow-owl-cis.launch core/com.b2international.snowowl.core/META-INF/MANIFEST.MF net4j/com.b2international.snowowl.eventbus.tests/.classpath net4j/com.b2international.snowowl.eventbus.tests/.launch/eventbus-unit-tests.launch net4j/com.b2international.snowowl.eventbus.tests/META-INF/MANIFEST.MF net4j/com.b2international.snowowl.eventbus/.classpath net4j/com.b2international.snowowl.eventbus/META-INF/MANIFEST.MF net4j/com.b2international.snowowl.rpc.test/.classpath net4j/com.b2international.snowowl.rpc.test/.launch/rpc-unit-tests.launch net4j/com.b2international.snowowl.rpc.test/META-INF/MANIFEST.MF net4j/com.b2international.snowowl.rpc.test/pom.xml net4j/com.b2international.snowowl.rpc/.classpath net4j/com.b2international.snowowl.rpc/META-INF/MANIFEST.MF
...generation support (module sun.security.x509 provides the relevant classes)
|
This pull request introduces 1 alert when merging aac22f0 into 3e773ca - view on LGTM.com new alerts:
|
...restore TransportConfiguration for timeouts and client-accepted certificate property.
This avoids leaking event loop groups in case multiple connection attempts are made from the splash screen.
|
@apeteri could you please resolve the conflicts and also port all recent change regard SSL transport to this PR from the 7.x branch? 🙇 |
feature/SO-4987_netty_eventbus_8x Conflicts: core/com.b2international.snowowl.core.tests/.launch/core-unit-tests.launch net4j/com.b2international.snowowl.eventbus.tests/META-INF/MANIFEST.MF net4j/com.b2international.snowowl.eventbus.tests/pom.xml net4j/com.b2international.snowowl.eventbus/META-INF/MANIFEST.MF net4j/com.b2international.snowowl.eventbus/pom.xml net4j/com.b2international.snowowl.rpc.test/META-INF/MANIFEST.MF net4j/com.b2international.snowowl.rpc.test/pom.xml net4j/com.b2international.snowowl.rpc/META-INF/MANIFEST.MF net4j/com.b2international.snowowl.rpc/pom.xml net4j/pom.xml releng/com.b2international.snowowl.server.update/assembly/common/bin/snowowl.bat releng/com.b2international.snowowl.server.update/assembly/common/bin/snowowl.sh
Codecov Report
@@ Coverage Diff @@
## 8.x #993 +/- ##
============================================
+ Coverage 64.67% 64.87% +0.19%
+ Complexity 12160 12138 -22
============================================
Files 1703 1696 -7
Lines 56635 56250 -385
Branches 5271 5199 -72
============================================
- Hits 36629 36492 -137
+ Misses 17770 17556 -214
+ Partials 2236 2202 -34
Continue to review full report at Codecov.
|
feature/SO-4987_netty_eventbus_8x Conflicts: net4j/com.b2international.snowowl.eventbus.tests/META-INF/MANIFEST.MF net4j/com.b2international.snowowl.eventbus.tests/pom.xml net4j/com.b2international.snowowl.eventbus/META-INF/MANIFEST.MF net4j/com.b2international.snowowl.eventbus/pom.xml net4j/com.b2international.snowowl.rpc.test/META-INF/MANIFEST.MF net4j/com.b2international.snowowl.rpc.test/pom.xml net4j/com.b2international.snowowl.rpc/META-INF/MANIFEST.MF net4j/com.b2international.snowowl.rpc/pom.xml net4j/pom.xml
...handler in Netty's handler chain
feature/SO-4987_netty_eventbus_8x Conflicts: net4j/com.b2international.snowowl.eventbus.tests/META-INF/MANIFEST.MF net4j/com.b2international.snowowl.eventbus.tests/pom.xml net4j/com.b2international.snowowl.eventbus/META-INF/MANIFEST.MF net4j/com.b2international.snowowl.eventbus/pom.xml net4j/com.b2international.snowowl.rpc.test/META-INF/MANIFEST.MF net4j/com.b2international.snowowl.rpc.test/pom.xml net4j/com.b2international.snowowl.rpc/META-INF/MANIFEST.MF net4j/com.b2international.snowowl.rpc/pom.xml net4j/pom.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.