SO-3966 fluent job wait retry api #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added an AsyncRequest.retryUntil() helper that polls the built request until a certain condition is met in the response.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 9.x #1233 +/- ##
=========================================
Coverage 64.03% 64.03%
- Complexity 13122 13143 +21
=========================================
Files 1795 1795
Lines 61371 61364 -7
Branches 5703 5706 +3
=========================================
- Hits 39300 39296 -4
+ Misses 19611 19602 -9
- Partials 2460 2466 +6
☔ View full report in Codecov by Sentry. |
Also rework to instantly register the document as soon as the request completes so that it is available when fetching it (no need to wait for the underlying job infrastructure to notify the listener and index the first version of the doc).
...contain the individual named counts
...job status polling properly
apeteri
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added an AsyncRequest.retryUntil() helper that polls the built request until a certain condition is met in the response.