Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO-5904: ECL search disable synonym token filter #1205

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

cmark
Copy link
Member

@cmark cmark commented Sep 11, 2023

This PR fixes a minor lexical search issue in ECL filtering related to using a search analyzer that includes synonyms of the search string. While this is okay for user interfaces, during ECL evaluation this should be disabled by default when using the match lexical search type.

https://snowowl.atlassian.net/browse/SO-5904

@cmark cmark added the bug label Sep 11, 2023
@cmark cmark requested review from apeteri and AAAlinaaa September 11, 2023 14:55
@cmark cmark self-assigned this Sep 11, 2023
@cmark cmark added the port-to-8.x Pull requests that need a complementary PR targeting the 8.x stream label Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 88.00% and project coverage change: +0.01% 🎉

Comparison is base (35cfefb) 64.08% compared to head (b97fe30) 64.09%.

Additional details and impacted files
@@             Coverage Diff              @@
##                9.x    #1205      +/-   ##
============================================
+ Coverage     64.08%   64.09%   +0.01%     
- Complexity    13135    13137       +2     
============================================
  Files          1799     1799              
  Lines         61519    61535      +16     
  Branches       5689     5690       +1     
============================================
+ Hits          39424    39441      +17     
+ Misses        19659    19656       -3     
- Partials       2436     2438       +2     
Files Changed Coverage Δ
...tional/snowowl/core/request/search/TermFilter.java 88.88% <ø> (ø)
...com/b2international/index/query/TextPredicate.java 85.29% <50.00%> (+4.04%) ⬆️
...l/snowowl/core/request/search/MatchTermFilter.java 76.31% <94.11%> (+5.54%) ⬆️
...snowowl/core/request/ecl/EclEvaluationRequest.java 79.82% <100.00%> (+0.26%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@cmark cmark merged commit ec8e19f into 9.x Sep 11, 2023
@cmark cmark deleted the issue/SO-5904-ecl-search-disable-synonyms branch September 11, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug port-to-8.x Pull requests that need a complementary PR targeting the 8.x stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants