Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect nested requests for permission checking recursively in TransactionalRequest and SnomedBulkRequest #1182

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented Jun 29, 2023

These usually appear with one packed into the other; if TransactionRequest stops at SnomedBulkRequest, there might not be enough information collected for permission checks.

...recursively in TransactionalRequest and SnomedBulkRequest
@apeteri apeteri added the bug label Jun 29, 2023
@apeteri apeteri requested review from cmark and nagyo June 29, 2023 10:16
@apeteri apeteri self-assigned this Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (909c633) 63.97% compared to head (ebd15c6) 63.97%.

Additional details and impacted files
@@             Coverage Diff              @@
##                8.x    #1182      +/-   ##
============================================
- Coverage     63.97%   63.97%   -0.01%     
- Complexity    12790    12791       +1     
============================================
  Files          1764     1764              
  Lines         59721    59742      +21     
  Branches       5520     5520              
============================================
+ Hits          38209    38218       +9     
- Misses        19133    19146      +13     
+ Partials       2379     2378       -1     
Impacted Files Coverage Δ
...nal/snowowl/core/request/TransactionalRequest.java 81.81% <100.00%> (+1.81%) ⬆️
...wl/snomed/datastore/request/SnomedBulkRequest.java 92.30% <100.00%> (+0.64%) ⬆️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

@nagyo nagyo merged commit d07d9f2 into 8.x Jun 29, 2023
@nagyo nagyo deleted the issue/SO-5827-nested-request-collection branch June 29, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants