SO-5811: fix FHIR publisher field selection #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## 8.x #1166 +/- ##
=========================================
Coverage 64.08% 64.08%
- Complexity 12775 12778 +3
=========================================
Files 1763 1763
Lines 59585 59587 +2
Branches 5497 5497
=========================================
+ Hits 38184 38186 +2
+ Misses 19032 19030 -2
- Partials 2369 2371 +2
☔ View full report in Codecov by Sentry. |
apeteri
requested changes
Jun 1, 2023
commons/com.b2international.index/src/com/b2international/index/mapping/DocumentMapping.java
Show resolved
Hide resolved
apeteri
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a bug when trying to load resource documents with the field selection of the settings field, which is a Map type field. Previously the system was unable to detect that this field cannot be loaded from doc_values, and unfortunately Elasticsearch does not throw an error when trying to load unindexed/unsupported/dynamic fields from doc_values.