Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO-5596: snapshot import with unpublished references #1157

Merged
merged 4 commits into from
May 10, 2023

Conversation

cmark
Copy link
Member

@cmark cmark commented May 10, 2023

No description provided.

cmark added 3 commits May 10, 2023 14:41
...versioned and unversioned content by putting them into a single
snapshot slice instead of separating the unpublished components from the
snapshot versioned content. (a versioned description referencing an
unversioned concept is considered a valid snapshot content)

Resolves https://snowowl.atlassian.net/browse/SO-5596
@cmark cmark added bug port-to-7.x Pull requests that need a complementary PR targeting the 7.x stream labels May 10, 2023
@cmark cmark requested review from nagyo and AAAlinaaa May 10, 2023 14:05
@cmark cmark self-assigned this May 10, 2023
@cmark
Copy link
Member Author

cmark commented May 10, 2023

7.x port PR available: #1159

Copy link
Contributor

@AAAlinaaa AAAlinaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (115275e) 64.05% compared to head (824e44e) 64.05%.

Additional details and impacted files
@@            Coverage Diff            @@
##                8.x    #1157   +/-   ##
=========================================
  Coverage     64.05%   64.05%           
- Complexity    12765    12768    +3     
=========================================
  Files          1763     1763           
  Lines         59596    59596           
  Branches       5496     5496           
=========================================
+ Hits          38172    38177    +5     
+ Misses        19048    19046    -2     
+ Partials       2376     2373    -3     
Impacted Files Coverage Δ
.../datastore/request/rf2/SnomedRf2ImportRequest.java 88.38% <100.00%> (+1.01%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

...import test cases

Assert that in case of a delta export of such RF2 content the system
responds with an error message.

Relates to https://snowowl.atlassian.net/browse/SO-5596
Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍏

@cmark cmark merged commit 1d9d190 into 8.x May 10, 2023
@cmark cmark deleted the issue/SO-5596-snapshot-import-with-unpublished-references branch May 10, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug port-to-7.x Pull requests that need a complementary PR targeting the 7.x stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants