Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add generic ID uniqueness and presence check step to each... #1156

Merged
merged 4 commits into from
May 9, 2023
Merged

feat(core): add generic ID uniqueness and presence check step to each... #1156

merged 4 commits into from
May 9, 2023

Conversation

cmark
Copy link
Member

@cmark cmark commented May 9, 2023

...transaction

@cmark cmark requested review from nagyo and molnarlaura May 9, 2023 14:41
@cmark cmark self-assigned this May 9, 2023
nagyo
nagyo approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (after fixing the typo and the missing javadoc)

...owowl.core/src/com/b2international/snowowl/core/repository/RepositoryTransactionContext.java Outdated Show resolved Hide resolved
Base automatically changed from feature/request-profiling to 8.x May 9, 2023 15:20
molnarlaura
molnarlaura approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@molnarlaura molnarlaura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@cmark cmark merged commit 11a0f9d into 8.x May 9, 2023
@cmark cmark deleted the feature/generic-uniqueness-presence-tx-checks branch May 9, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molnarlaura molnarlaura molnarlaura approved these changes

@nagyo nagyo nagyo approved these changes

Assignees

@cmark cmark

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmark @nagyo @molnarlaura