Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Promise response header propagation #1119

Merged
merged 11 commits into from
Mar 7, 2023

Conversation

cmark
Copy link
Member

@cmark cmark commented Mar 3, 2023

No description provided.

@cmark cmark requested review from apeteri and nagyo March 3, 2023 13:02
@cmark cmark self-assigned this Mar 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2023

Codecov Report

Patch coverage: 77.77% and project coverage change: +0.09 🎉

Comparison is base (89bfd31) 64.02% compared to head (590c3cd) 64.12%.

Additional details and impacted files
@@             Coverage Diff              @@
##                8.x    #1119      +/-   ##
============================================
+ Coverage     64.02%   64.12%   +0.09%     
- Complexity    12602    12642      +40     
============================================
  Files          1755     1755              
  Lines         58977    59028      +51     
  Branches       5438     5440       +2     
============================================
+ Hits          37760    37851      +91     
+ Misses        18863    18825      -38     
+ Partials       2354     2352       -2     
Impacted Files Coverage Δ
...ational/snowowl/core/rate/RateLimitingRequest.java 100.00% <ø> (+16.66%) ⬆️
...ternational/snowowl/core/events/util/Response.java 64.70% <50.00%> (-18.63%) ⬇️
...ore/rest/util/PromiseMethodReturnValueHandler.java 66.66% <70.00%> (+1.04%) ⬆️
...nternational/snowowl/core/events/util/Promise.java 83.57% <89.18%> (+8.57%) ⬆️
...m/b2international/snowowl/core/rate/ApiPlugin.java 100.00% <100.00%> (+30.00%) ⬆️
.../b2international/index/es/client/EsClientBase.java 67.36% <0.00%> (-1.06%) ⬇️
...national/index/revision/BaseRevisionBranching.java 90.64% <0.00%> (+1.16%) ⬆️
...onal/snowowl/snomed/core/tree/TerminologyTree.java 87.23% <0.00%> (+2.12%) ⬆️
...c/com/b2international/index/revision/ObjectId.java 84.00% <0.00%> (+4.00%) ⬆️
...l/snowowl/core/rest/ControllerExceptionMapper.java 42.22% <0.00%> (+6.66%) ⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmark cmark marked this pull request as ready for review March 6, 2023 12:31
@cmark cmark marked this pull request as draft March 6, 2023 12:32
@cmark cmark marked this pull request as ready for review March 7, 2023 08:19
Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with a small note.

Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmark cmark merged commit 9f00fa7 into 8.x Mar 7, 2023
@cmark cmark deleted the issue/promise-response-header-propagation branch March 7, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants