-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken Promise response header propagation #1119
Conversation
...successful promise response
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## 8.x #1119 +/- ##
============================================
+ Coverage 64.02% 64.12% +0.09%
- Complexity 12602 12642 +40
============================================
Files 1755 1755
Lines 58977 59028 +51
Branches 5438 5440 +2
============================================
+ Hits 37760 37851 +91
+ Misses 18863 18825 -38
+ Partials 2354 2352 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
...for HTTP 200 responses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 with a small note.
...ore.rest/src/com/b2international/snowowl/core/rest/util/PromiseMethodReturnValueHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.