Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fhir.core): Use "createdAt" for point-in-time resource document... #1086

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented Nov 17, 2022

...queries instead of "created"'s timestamp portion for backwards compatibility in datasets where no FHIR resource metadata is stored on version documents.

...queries instead of "created"'s timestamp portion for backwards
compatibility in datasets where no FHIR resource metadata is stored on
version documents.
@apeteri apeteri added the bug label Nov 17, 2022
@apeteri apeteri requested review from cmark and nagyo November 17, 2022 14:47
@apeteri apeteri self-assigned this Nov 17, 2022
Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

@codecov-commenter
Copy link

Codecov Report

Base: 64.23% // Head: 64.24% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (4031e11) compared to base (830f966).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##                8.x    #1086   +/-   ##
=========================================
  Coverage     64.23%   64.24%           
- Complexity    12467    12469    +2     
=========================================
  Files          1734     1734           
  Lines         58217    58219    +2     
  Branches       5372     5373    +1     
=========================================
+ Hits          37396    37400    +4     
  Misses        18506    18506           
+ Partials       2315     2313    -2     
Impacted Files Coverage Δ
...l/fhir/core/request/FhirResourceSearchRequest.java 76.23% <33.33%> (-0.27%) ⬇️
.../snomed/core/ecl/SnomedEclRefinementEvaluator.java 85.27% <0.00%> (+0.25%) ⬆️
...index/src/com/b2international/index/es/EsNode.java 82.29% <0.00%> (+1.04%) ⬆️
...onal/snowowl/snomed/core/tree/TerminologyTree.java 87.23% <0.00%> (+2.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmark cmark merged commit d5a192d into 8.x Nov 18, 2022
@cmark cmark deleted the issue/SNRAY-1117-fhir-resource-search-summary branch November 18, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants