Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fhir): support withHistorySupplements in ExpandValueSetRequest #1076

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

cmark
Copy link
Member

@cmark cmark commented Nov 9, 2022

No description provided.

@cmark cmark requested a review from apeteri November 9, 2022 16:15
@cmark cmark self-assigned this Nov 9, 2022
@cmark cmark requested a review from nagyo November 9, 2022 16:15
Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

Base: 64.24% // Head: 64.23% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (14ced6d) compared to base (352192c).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##                8.x    #1076      +/-   ##
============================================
- Coverage     64.24%   64.23%   -0.01%     
  Complexity    12469    12469              
============================================
  Files          1734     1734              
  Lines         58212    58217       +5     
  Branches       5372     5372              
============================================
+ Hits          37397    37398       +1     
- Misses        18504    18507       +3     
- Partials       2311     2312       +1     
Impacted Files Coverage Δ
...hir/core/model/valueset/ExpandValueSetRequest.java 69.64% <75.00%> (-0.46%) ⬇️
...onal/snowowl/snomed/core/tree/TerminologyTree.java 85.10% <0.00%> (-2.13%) ⬇️
.../snomed/core/ecl/SnomedEclRefinementEvaluator.java 85.01% <0.00%> (-0.26%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmark cmark merged commit 830f966 into 8.x Nov 9, 2022
@cmark cmark deleted the issue/SO-5551-valueset-expand-history-supplements branch November 9, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants