Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for "settings" property on all resource types #1034

Merged
merged 5 commits into from
Jun 28, 2022
Merged

Add support for "settings" property on all resource types #1034

merged 5 commits into from
Jun 28, 2022

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented Jun 28, 2022

No description provided.

@apeteri apeteri requested review from cmark and molnarlaura June 28, 2022 16:19
@apeteri apeteri self-assigned this Jun 28, 2022
molnarlaura
molnarlaura approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@molnarlaura molnarlaura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cmark
cmark approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@cmark cmark merged commit eb9d3ce into 8.x Jun 28, 2022
@cmark cmark deleted the feature/SO-5509-bundle-settings-support branch June 28, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molnarlaura molnarlaura molnarlaura approved these changes

@cmark cmark cmark approved these changes

Assignees

@apeteri apeteri

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apeteri @cmark @molnarlaura