Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SO-5679: Add missing operators to content assist #9

Merged
merged 2 commits into from
Oct 3, 2024
Merged

SO-5679: Add missing operators to content assist #9

merged 2 commits into from
Oct 3, 2024

Conversation

adamfilep
Copy link
Contributor

No description provided.

@adamfilep adamfilep requested review from cmark and apeteri July 30, 2024 17:20
@adamfilep adamfilep self-assigned this Jul 30, 2024
@adamfilep adamfilep marked this pull request as ready for review July 31, 2024 08:56
cmark
cmark approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM!

apeteri
apeteri approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

In the Eclipse UI provider there is a "bonus fix" for context-dependent suggestion of < and > operators which we will add to the IDE (language server) provider at a later time.

@apeteri apeteri merged commit f5f5d55 into main Oct 3, 2024
1 check passed
@apeteri apeteri deleted the issue/SO-5679-ecl-content-assist branch October 3, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmark cmark cmark approved these changes

@apeteri apeteri apeteri approved these changes

Assignees

@adamfilep adamfilep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamfilep @cmark @apeteri