Added support for Docker #3
Conversation
Dockerfile
Outdated
| COPY . . | ||
| RUN npm install | ||
| VOLUME ["/files"] | ||
| ENTRYPOINT [ "sh", "convert.sh" ] |
convert.sh
Outdated
| if test -f "${dir}.pdf"; then | ||
| rm $dir.pdf | ||
| fi |
There was a problem hiding this comment.
It's a bad practice to test and then rm. Instead, always use rm -f.
convert.sh
Outdated
| if test -f "${dir}.png"; then | ||
| rm $dir.png | ||
| fi |
.gitignore
Outdated
|
|
||
| ./project | ||
| project | ||
| package-lock.json |
There was a problem hiding this comment.
package-lock.json shall NOT be put into .gitignore. This repo is using yarn, but the choice was made back in 2018. I moved to npm on master and plz rebase.
.dockerignore
Outdated
| Dockerfile | ||
| .git | ||
| ./files/* | ||
| .gitignore |
Dockerfile
Outdated
| RUN mkdir -p /home/node/draw.io-export /files | ||
| WORKDIR /home/node/draw.io-export | ||
| COPY . . | ||
| RUN npm install |
There was a problem hiding this comment.
Use npm ci --only=production instead of npm install.
There was a problem hiding this comment.
Further, consider COPY package*.json ./ first before COPY . ., as stated in this guide.
Dockerfile
Outdated
| FROM node:lts-alpine3.11 | ||
| RUN apk add chromium | ||
| ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD true | ||
| ENV CHROMIUM_PATH /usr/bin/chromium-browser | ||
| RUN mkdir -p /home/node/draw.io-export /files |
convert.sh
Outdated
| @@ -0,0 +1,17 @@ | |||
| echo "DRAW.IO-EXPORT Started." | |||
convert.sh
Outdated
| dirs=$(find /files -name '*.drawio') | ||
|
|
||
| for dir in $dirs | ||
| do |
There was a problem hiding this comment.
This scripts will fail if any of the files contains "abnormal" characters, like spaces.
Please consider write a separate script file convert-one.sh and do :
find /files -name '*.drawio' -exec ./convert-one.sh {} \;
Alternatively, you can try combining the two scripts together and, at the beginning of the script, check [ "$#" -eq 1 ] to know if the script is called by find or by docker.
Please review all changes including changes to Chromium installation