Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of craftable Items are not shown on Alchemy Profession #194

Open
larsschweier opened this issue Dec 23, 2024 · 7 comments
Open

Number of craftable Items are not shown on Alchemy Profession #194

larsschweier opened this issue Dec 23, 2024 · 7 comments

Comments

@larsschweier
Copy link

In the German client, the display for the potions that can be produced does not work for alchemy.

First aid and cooking work perfectly.

Unfortunately I don't get an error message.
Screenshot 2024-12-23 193333
Screenshot 2024-12-23 193437

@b-morgan
Copy link
Owner

Unfortunately, I don't have a Classic Era Alchemist but before I make one, let's check something first.

The upper right side of the recipe list has an icon with a bag. Right-click that icon and verify that the first four (or all five) icons are selected. These settings are profession specific.

If that isn't the problem, let me know and we'll figure out what next to try.

@larsschweier
Copy link
Author

larsschweier commented Dec 24, 2024

Everything is activated. I've just switched off the alts now so you can see the difference.

I tried a bit more now, if I have the mats in the pockets, it shows it, but the things on the bank and alts are ignored

grafik

@b-morgan
Copy link
Owner

I believe I now see the issue and it is not limited to Alchemy.

The numbers in the recipe list are how many completed you own (blue); how many you could make with materials in your bags, green; how many you could craft, yellow; vendor, orange; and alts, purple. The numbers in the tooltip are how many in your inventory / bank / craftable.

On Classic Era, you cannot craft from the bank so those numbers next to the recipe are zero when the materials are in the bank. Same with alts, the materials have to be in their inventory. One could argue that for alts, it should count their bank as well because you would have to transfer the items to this character to craft, but that's a separate issue (it does work this way for Cataclysm Classic and the alt count includes the characters own bank).

The craft count applies to things like bolts of cloth vs the cloth itself. If a tailoring recipe calls for bolts of linen and you have enough linen cloth in your inventory to make the number of bolts required for that recipe, then the craft count(s) will show how many of that item you could make if you converted the linen cloth to bolts.

The vendor count will show the number you could craft if you have all the materials except those purchased from a vendor. For example, alchemy potions require vials which can be purchased from a vendor. If you have all the materials except the vials, then the vendor count should reflect that.

The change between Cataclysm Classic and Classic Era of using the bank count in the alt count is controlled by a (hidden) option. Change line 447 in SkilletOptions.lua to "hidden = false" and that option will become available on Classic Era.

Let me know if this makes sense and what changes you would make (besides making that option available on Classic Era because I think I'll do that).

@larsschweier
Copy link
Author

Oh ok, then I misinterpreted that the whole time. I thought a display was also there to show how many I can craft in total, even if I have the materials in the bank. Would that be possible? I just store all crafting items on bank characters or in the character's bank. It would just make it a lot easier.

@b-morgan
Copy link
Owner

If you change line 447 in SkilletOptions.lua to "hidden = false" and then open Skillet options (? icon) and check "Use bank as another alt" (I just checked the localization and that phrase has not been translated). Turn on the Alts (fifth) option and you will have most of what you want. It will show the number you can craft including your bank and the alt's inventories (if you have logged in to each alt with Skillet-Classic enabled).

I am going to add that option to all Classic Era versions.

I will look into including the alt's bank as well but this will not be easy. I'll post here if there's an alpha version to try.

@b-morgan
Copy link
Owner

Skillet-Classic-2.06-alpha2 contains the "Use bank as another alt" and "Use alt banks" options and code to update the saved variables with the data necessary to implement the second option (which doesn't do anything yet).

Since the saved variables data has changed, let me know if anything strange happens.

@larsschweier
Copy link
Author

I've had this version for 2 days. No problems so far. I already love the option to display the number of craftable items with the materials on the bank. Many thanks already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants