feat: precompiled contract poc #1

dudong2 · 2024-08-23T08:27:26Z

this changes are based on crypto-org-chain#12

jasonsong0

It's better to mention the cherry-picked commits for follow-up.
It seems to be based on the commit
There isn't much information on what is resolved by this fix, but it needs to be checked.
Please check if the code should be changed to vm.DefaultActivePrecompiles

go-ethereum/core/vm/runtime/runtime.go

Line 132 in 9dcf8aa

cfg.State.Prepare(rules, cfg.Origin, cfg.Coinbase, &address, vm.ActivePrecompiles(rules), nil)

go-ethereum/core/vm/runtime/runtime.go

Line 168 in 9dcf8aa

cfg.State.Prepare(rules, cfg.Origin, cfg.Coinbase, nil, vm.ActivePrecompiles(rules), nil)

go-ethereum/core/vm/runtime/runtime.go

Line 199 in 9dcf8aa

statedb.Prepare(rules, cfg.Origin, cfg.Coinbase, &address, vm.ActivePrecompiles(rules), nil)

dudong2 · 2024-09-09T03:36:33Z

It's better to mention the cherry-picked commits for follow-up.
It seems to be based on the commit

this pr was done with reference to crypto-org-chain#12. i mentioned url in description.

There isn't much information on what is resolved by this fix, but it needs to be checked.

for big2, there is a history of being added and removed.
no additional information exists, but i think it was an fault.

dudong2 · 2024-09-09T03:39:11Z

Please check if the code should be changed to vm.DefaultActivePrecompiles

go-ethereum/core/vm/runtime/runtime.go

Line 132 in 9dcf8aa

cfg.State.Prepare(rules, cfg.Origin, cfg.Coinbase, &address, vm.ActivePrecompiles(rules), nil)

go-ethereum/core/vm/runtime/runtime.go

Line 168 in 9dcf8aa

cfg.State.Prepare(rules, cfg.Origin, cfg.Coinbase, nil, vm.ActivePrecompiles(rules), nil)

go-ethereum/core/vm/runtime/runtime.go

Line 199 in 9dcf8aa

statedb.Prepare(rules, cfg.Origin, cfg.Coinbase, &address, vm.ActivePrecompiles(rules), nil)

these have been changed to vmevm.ActivePrecompiles(rules) and also fixed the part of the test code that was causing the build to fail.

jasonsong0 · 2024-09-11T03:42:43Z

LGTM

cloudgray · 2024-09-11T07:42:58Z

Please check if the code should be changed to vm.DefaultActivePrecompiles

go-ethereum/core/vm/runtime/runtime.go

Line 132 in 9dcf8aa

cfg.State.Prepare(rules, cfg.Origin, cfg.Coinbase, &address, vm.ActivePrecompiles(rules), nil)

go-ethereum/core/vm/runtime/runtime.go

Line 168 in 9dcf8aa

cfg.State.Prepare(rules, cfg.Origin, cfg.Coinbase, nil, vm.ActivePrecompiles(rules), nil)

go-ethereum/core/vm/runtime/runtime.go

Line 199 in 9dcf8aa

statedb.Prepare(rules, cfg.Origin, cfg.Coinbase, &address, vm.ActivePrecompiles(rules), nil)

these have been changed to vmevm.ActivePrecompiles(rules) and also fixed the part of the test code that was causing the build to fail.

I checked fix test build commit, and I think these three parts are not related to build failure.

[Suggestion]
When I change vmenv.ActivePrecompiles to vm.DefaultActivePrecompiles of these three parts and build, it works.
Of course it is extension of vm.DefaultActivePrecompiles and it has not impact to ethermint and basechain.
But it can impact independent working of this go-etherum fork.
It is not required but suggesion that we use vm.DefaultActivePrecompiles to these 3 parts.

cloudgray · 2024-09-11T08:06:09Z

internal/ethapi/api.go

@@ -1405,7 +1405,7 @@ func AccessList(ctx context.Context, b Backend, blockNrOrHash rpc.BlockNumberOrH
 	}
 	isPostMerge := header.Difficulty.Cmp(common.Big0) == 0
 	// Retrieve the precompiles since they don't need to be added to the access list
-	precompiles := vm.ActivePrecompiles(b.ChainConfig().Rules(header.Number, isPostMerge))
+	precompiles := vm.DefaultActivePrecompiles(b.ChainConfig().Rules(header.Number, isPostMerge))


[Optional] If we use vmenv.ActivePrecompiles instead of vm.DefaultActivePrecompiles in go-ethereum/core/vm/runtime/runtime.go, I think same change should be applied to this part.

I reverted changes in runtime.go.
Execute, Create, Call functions are performed via evm binary, which is the evm executor.
The point at which the precompiled contract address is added to the active precompiles list is when ethermint executes an evm tx, so there is no need to change to ActivePrecompiles in parts that do not have this access route.

cloudgray

I have some suggestions but entirely, LGTM.

* feat: app level precompile * chore: Fix test build * chore: Remove usused var big2 * chore: Revert ActivePrecompiles to DefaultActivePrecompilestest: Fix gofumpt, gci

* feat: precompiled contract poc (#1) * feat: app level precompile * chore: Fix test build * chore: Remove usused var big2 * chore: Revert ActivePrecompiles to DefaultActivePrecompilestest: Fix gofumpt, gci * fix resolve * Merge pull request ethereum#18 from yihuang/release/v1.11.x go.mod: bump pebble db to official release --------- Co-authored-by: mmsqe <[email protected]> Co-authored-by: yihuang <[email protected]>

feat: app level precompile

9e19164

dudong2 changed the title ~~feat: app level precompile~~ feat: precompiled contract Aug 23, 2024

dudong2 changed the title ~~feat: precompiled contract~~ feat: precompiled contract poc Aug 23, 2024

dudong2 changed the base branch from basechain/v1.10.19 to basechain/abci1.0/delevelop August 31, 2024 05:30

dudong2 marked this pull request as ready for review August 31, 2024 05:31

dudong2 requested a review from jasonsong0 September 2, 2024 02:29

jasonsong0 reviewed Sep 4, 2024

View reviewed changes

dudong2 self-assigned this Sep 9, 2024

chore: Fix test build

bbf7219

dudong2 added the enhancement New feature or request label Sep 9, 2024

chore: Remove usused var big2

1d4be49

dudong2 changed the base branch from basechain/abci1.0/delevelop to basechain/abci1.0/develop September 9, 2024 09:00

dongsam requested a review from cloudgray September 11, 2024 02:31

This comment was marked as duplicate.

Sign in to view

cloudgray self-requested a review September 11, 2024 06:17

cloudgray reviewed Sep 11, 2024

View reviewed changes

chore: Revert ActivePrecompiles to DefaultActivePrecompiles

393bfcf

dudong2 requested review from jasonsong0 and cloudgray September 11, 2024 10:22

dudong2 merged commit ceb46ab into basechain/abci1.0/develop Sep 11, 2024

dudong2 deleted the feat/precompiled-bank-contract branch September 11, 2024 10:43

dudong2 added a commit that referenced this pull request Sep 25, 2024

feat: Cherry-pick precompile [pr](#1)

5fa8b77

dudong2 added a commit that referenced this pull request Nov 4, 2024

feat: precompiled contract poc (#1)

57b66e0

* feat: app level precompile * chore: Fix test build * chore: Remove usused var big2 * chore: Revert ActivePrecompiles to DefaultActivePrecompilestest: Fix gofumpt, gci

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: precompiled contract poc #1

feat: precompiled contract poc #1

dudong2 commented Aug 23, 2024 •

edited

Loading

jasonsong0 left a comment

dudong2 commented Sep 9, 2024 •

edited

Loading

dudong2 commented Sep 9, 2024

jasonsong0 commented Sep 11, 2024

This comment was marked as duplicate.

cloudgray commented Sep 11, 2024 •

edited

Loading

cloudgray Sep 11, 2024

dudong2 Sep 11, 2024 •

edited

Loading

cloudgray left a comment

feat: precompiled contract poc #1

feat: precompiled contract poc #1

Conversation

dudong2 commented Aug 23, 2024 • edited Loading

jasonsong0 left a comment

Choose a reason for hiding this comment

dudong2 commented Sep 9, 2024 • edited Loading

dudong2 commented Sep 9, 2024

jasonsong0 commented Sep 11, 2024

This comment was marked as duplicate.

cloudgray commented Sep 11, 2024 • edited Loading

cloudgray Sep 11, 2024

Choose a reason for hiding this comment

dudong2 Sep 11, 2024 • edited Loading

Choose a reason for hiding this comment

cloudgray left a comment

Choose a reason for hiding this comment

dudong2 commented Aug 23, 2024 •

edited

Loading

dudong2 commented Sep 9, 2024 •

edited

Loading

cloudgray commented Sep 11, 2024 •

edited

Loading

dudong2 Sep 11, 2024 •

edited

Loading