Skip to content

Commit

Permalink
[Core/OpenTelemetry] Fixed spelling errors (Azure#25610)
Browse files Browse the repository at this point in the history
* fix: typo, cspell config

* fix: second typos

* cspell: move inline to cspell.json

Co-authored-by: Xiang Yan <[email protected]>
  • Loading branch information
wonhyeongseo and xiangyan99 authored Oct 18, 2022
1 parent b200856 commit caadcf0
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 11 deletions.
5 changes: 5 additions & 0 deletions .vscode/cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
"sdk/communication/azure-communication-sms/**",
"sdk/core/azure/**",
"sdk/core/azure-common/**",
"sdk/core/azure-core-tracing-opencensus/**",
"sdk/core/azure-core-tracing-opentelemetry/**",
"sdk/core/azure-servicemanagement-legacy/**",
"sdk/digitaltwins/azure-digitaltwins-core/**",
Expand Down Expand Up @@ -458,6 +459,10 @@
"FHIR"
]
},
{
"filename": "sdk/core/azure-core-tracing-opentelemetry/**",
"words": ["ctxt", "somethingstuid"]
},
{
"filename": "sdk/cognitivelanguage/azure-ai-language-conversations/**",
"words": ["conv"],
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/azure-core-tracing-opentelemetry/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ from azure.storage.blob import BlobServiceClient

with tracer.start_as_current_span(name="MyApplication"):
client = BlobServiceClient.from_connection_string('connectionstring')
client.create_container('mycontainer') # Call will be traced
client.create_container('my_container') # Call will be traced
```

Azure Exporter can be found in the [package](https://pypi.org/project/opentelemetry-azure-monitor-exporter/) `opentelemetry-azure-monitor-exporter`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,8 @@ def kind(self, value):
self._span_instance._kind = kind # pylint: disable=protected-access
except AttributeError:
warnings.warn(
"""Kind must be set while creating the span for Opentelemetry. It might be possible
that one of the packages you are using doesn't follow the latest Opentelemtry Spec.
"""Kind must be set while creating the span for OpenTelemetry. It might be possible
that one of the packages you are using doesn't follow the latest Opentelemetry Spec.
Try updating the azure packages to the latest versions."""
)

Expand Down Expand Up @@ -233,8 +233,8 @@ def link_from_headers(cls, headers, attributes=None):
current_span._links.append(OpenTelemetryLink(span_ctx, attributes)) # pylint: disable=protected-access
except AttributeError:
warnings.warn(
"""Link must be added while creating the span for Opentelemetry. It might be possible
that one of the packages you are using doesn't follow the latest Opentelemtry Spec.
"""Link must be added while creating the span for OpenTelemetry. It might be possible
that one of the packages you are using doesn't follow the latest Opentelemetry Spec.
Try updating the azure packages to the latest versions."""
)

Expand Down
6 changes: 3 additions & 3 deletions sdk/core/azure-core-tracing-opentelemetry/samples/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ products:
urlFragment: azure-core-tracing-opentelemetry-samples
---

# Azure Core Tracing Opentelemetry Integration Python Samples
# Azure Core Tracing OpenTelemetry Integration Python Samples

These code samples show using the tracing opentelemetry integration with few services including servicebus, storage and eventgrid. A simple console span exporter is used in this example to export the calls. However, the code to use the azure monitor exporter has also been provided and commented in each sample.
These code samples show using the tracing OpenTelemetry integration with few services including servicebus, storage and eventgrid. A simple console span exporter is used in this example to export the calls. However, the code to use the azure monitor exporter has also been provided and commented in each sample.

* Trace Storage Calls to create a container: [sample_storage.py][python-sample-storage]
* Trace Eventgrid calls to publish an event : [sample_eventgrid.py][python-sample-eventgrid]
Expand All @@ -24,7 +24,7 @@ It is assumed that the relevant SDKs are installed along with this extension. Be
- [azure-servicebus](https://pypi.org/project/azure-servicebus) v7 or greater.
- [azure-eventgrid](https://pypi.org/project/azure-eventgrid) v4 or greater.
- [azure-eventhub](https://pypi.org/project/azure-eventhub/) v5 or greater
- [opentelemtry-sdk](https://pypi.org/project/opentelemetry-sdk/)
- [opentelemetry-sdk](https://pypi.org/project/opentelemetry-sdk/)

[python-sample-storage]: https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/core/azure-core-tracing-opentelemetry/samples/sample_storage.py
[python-sample-eventgrid]: https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/core/azure-core-tracing-opentelemetry/samples/sample_eventgrid.py
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Examples to show usage of the azure-core-tracing-opentelemetry
with the Eventhub SDK.
This example traces calls for senda batch to eventhub.
This example traces calls for sending a batch to eventhub.
An alternative path to export using AzureMonitor is also mentioned in the sample. Please take
a look at the commented code.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Examples to show usage of the azure-core-tracing-opentelemetry
with the Eventhub SDK.
This example traces calls for senda batch to eventhub.
This example traces calls for sending a batch to eventhub.
An alternative path to export using AzureMonitor is also mentioned in the sample. Please take
a look at the commented code.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -188,4 +188,4 @@ def test_span_kind(self, tracer):
assert wrapped_class.kind == SpanKind.INTERNAL

with pytest.raises(ValueError):
wrapped_class.kind = "somethingstuid"
wrapped_class.kind = "somethingstuid"

0 comments on commit caadcf0

Please sign in to comment.