Skip to content

Commit

Permalink
CodeGen from PR 19882 in Azure/azure-rest-api-specs
Browse files Browse the repository at this point in the history
[Hub Generated] Publish private branch 'user/jimmyca/fixAppConfigSpec' (Azure#19882)

* Update swagger to match service implementation.
* Remove list key values operation.
* Update description for PUT private endpoint connection to be clear it can't be used to create.
* Added example for list operations API.

* Add suggested message.

* Fix lint errors.

* Fix prettier and avocado.

* fix model validation with LRO header.
  • Loading branch information
SDKAuto committed Feb 3, 2023
1 parent 7926d22 commit d63d077
Show file tree
Hide file tree
Showing 17 changed files with 75 additions and 332 deletions.
21 changes: 11 additions & 10 deletions sdk/appconfiguration/arm-appconfiguration/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
# Release History

## 4.0.0 (2023-02-03)

**Breaking Changes**

## 3.1.1 (Unreleased)

### Features Added

### Breaking Changes

### Bugs Fixed

### Other Changes

- Removed operation KeyValues.listByConfigurationStore
- Interface ConfigurationStoresListByResourceGroupNextOptionalParams no longer has parameter skipToken
- Interface ConfigurationStoresListKeysNextOptionalParams no longer has parameter skipToken
- Interface ConfigurationStoresListNextOptionalParams no longer has parameter skipToken
- Interface OperationsListNextOptionalParams no longer has parameter skipToken


## 3.1.0 (2022-11-15)

**Features**
Expand Down
2 changes: 1 addition & 1 deletion sdk/appconfiguration/arm-appconfiguration/LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2022 Microsoft
Copyright (c) 2023 Microsoft

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
10 changes: 5 additions & 5 deletions sdk/appconfiguration/arm-appconfiguration/_meta.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"commit": "60cd4dbca5214118b763d1edc835a44c8386283a",
"readme": "specification\\appconfiguration\\resource-manager\\readme.md",
"autorest_command": "autorest --version=3.8.4 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=D:\\Git\\azure-sdk-for-js ..\\azure-rest-api-specs\\specification\\appconfiguration\\resource-manager\\readme.md --use=@autorest/[email protected].3.20221108.1 --generate-sample=true",
"commit": "2c4244e5bcb8939167b79f633cdc17a1f0eae9be",
"readme": "specification/appconfiguration/resource-manager/readme.md",
"autorest_command": "autorest --version=3.9.3 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/appconfiguration/resource-manager/readme.md --use=@autorest/[email protected].5",
"repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
"release_tool": "@azure-tools/js-sdk-release-tools@2.4.2",
"use": "@autorest/[email protected].3.20221108.1"
"release_tool": "@azure-tools/js-sdk-release-tools@2.6.1",
"use": "@autorest/[email protected].5"
}
14 changes: 3 additions & 11 deletions sdk/appconfiguration/arm-appconfiguration/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"sdk-type": "mgmt",
"author": "Microsoft Corporation",
"description": "A generated SDK for AppConfigurationManagementClient.",
"version": "3.1.1",
"version": "4.0.0",
"engines": {
"node": ">=14.0.0"
},
Expand Down Expand Up @@ -110,13 +110,5 @@
}
]
},
"autoPublish": true,
"//sampleConfiguration": {
"productName": "",
"productSlugs": [
"azure"
],
"disableDocsMs": true,
"apiRefLink": "https://docs.microsoft.com/javascript/api/@azure/arm-appconfiguration?view=azure-node-preview"
}
}
"autoPublish": true
}
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ export type ConfigurationStoresGetResponse = ConfigurationStore;

// @public
export interface ConfigurationStoresListByResourceGroupNextOptionalParams extends coreClient.OperationOptions {
skipToken?: string;
}

// @public
Expand Down Expand Up @@ -169,7 +168,6 @@ export type ConfigurationStoresListDeletedResponse = DeletedConfigurationStoreLi

// @public
export interface ConfigurationStoresListKeysNextOptionalParams extends coreClient.OperationOptions {
skipToken?: string;
}

// @public
Expand All @@ -185,7 +183,6 @@ export type ConfigurationStoresListKeysResponse = ApiKeyListResult;

// @public
export interface ConfigurationStoresListNextOptionalParams extends coreClient.OperationOptions {
skipToken?: string;
}

// @public
Expand Down Expand Up @@ -322,7 +319,6 @@ export interface KeyValues {
beginDeleteAndWait(resourceGroupName: string, configStoreName: string, keyValueName: string, options?: KeyValuesDeleteOptionalParams): Promise<void>;
createOrUpdate(resourceGroupName: string, configStoreName: string, keyValueName: string, options?: KeyValuesCreateOrUpdateOptionalParams): Promise<KeyValuesCreateOrUpdateResponse>;
get(resourceGroupName: string, configStoreName: string, keyValueName: string, options?: KeyValuesGetOptionalParams): Promise<KeyValuesGetResponse>;
listByConfigurationStore(resourceGroupName: string, configStoreName: string, options?: KeyValuesListByConfigurationStoreOptionalParams): PagedAsyncIterableIterator<KeyValue>;
}

// @public
Expand All @@ -346,22 +342,6 @@ export interface KeyValuesGetOptionalParams extends coreClient.OperationOptions
// @public
export type KeyValuesGetResponse = KeyValue;

// @public
export interface KeyValuesListByConfigurationStoreNextOptionalParams extends coreClient.OperationOptions {
skipToken?: string;
}

// @public
export type KeyValuesListByConfigurationStoreNextResponse = KeyValueListResult;

// @public
export interface KeyValuesListByConfigurationStoreOptionalParams extends coreClient.OperationOptions {
skipToken?: string;
}

// @public
export type KeyValuesListByConfigurationStoreResponse = KeyValueListResult;

// @public
export interface KeyVaultProperties {
identityClientId?: string;
Expand Down Expand Up @@ -496,7 +476,6 @@ export type OperationsCheckNameAvailabilityResponse = NameAvailabilityStatus;

// @public
export interface OperationsListNextOptionalParams extends coreClient.OperationOptions {
skipToken?: string;
}

// @public
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export class AppConfigurationManagementClient extends coreClient.ServiceClient {
credential: credentials
};

const packageDetails = `azsdk-js-arm-appconfiguration/3.1.1`;
const packageDetails = `azsdk-js-arm-appconfiguration/4.0.0`;
const userAgentPrefix =
options.userAgentOptions && options.userAgentOptions.userAgentPrefix
? `${options.userAgentOptions.userAgentPrefix} ${packageDetails}`
Expand Down
56 changes: 12 additions & 44 deletions sdk/appconfiguration/arm-appconfiguration/src/models/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -451,14 +451,6 @@ export interface PrivateLinkResource {
readonly requiredZoneNames?: string[];
}

/** The result of a request to list key-values. */
export interface KeyValueListResult {
/** The collection value. */
value?: KeyValue[];
/** The URI that can be used to request the next set of paged results. */
nextLink?: string;
}

/** The key-value resource along with all resource properties. */
export interface KeyValue {
/**
Expand Down Expand Up @@ -572,6 +564,14 @@ export interface DeletedConfigurationStore {
readonly purgeProtectionEnabled?: boolean;
}

/** The result of a request to list key-values. */
export interface KeyValueListResult {
/** The collection value. */
value?: KeyValue[];
/** The URI that can be used to request the next set of paged results. */
nextLink?: string;
}

/** The resource model definition for an Azure Resource Manager tracked top level resource which has 'tags' and a 'location' */
export interface TrackedResource extends Resource {
/** Resource tags. */
Expand Down Expand Up @@ -882,30 +882,21 @@ export interface ConfigurationStoresPurgeDeletedOptionalParams

/** Optional parameters. */
export interface ConfigurationStoresListNextOptionalParams
extends coreClient.OperationOptions {
/** A skip token is used to continue retrieving items after an operation returns a partial result. If a previous response contains a nextLink element, the value of the nextLink element will include a skipToken parameter that specifies a starting point to use for subsequent calls. */
skipToken?: string;
}
extends coreClient.OperationOptions {}

/** Contains response data for the listNext operation. */
export type ConfigurationStoresListNextResponse = ConfigurationStoreListResult;

/** Optional parameters. */
export interface ConfigurationStoresListByResourceGroupNextOptionalParams
extends coreClient.OperationOptions {
/** A skip token is used to continue retrieving items after an operation returns a partial result. If a previous response contains a nextLink element, the value of the nextLink element will include a skipToken parameter that specifies a starting point to use for subsequent calls. */
skipToken?: string;
}
extends coreClient.OperationOptions {}

/** Contains response data for the listByResourceGroupNext operation. */
export type ConfigurationStoresListByResourceGroupNextResponse = ConfigurationStoreListResult;

/** Optional parameters. */
export interface ConfigurationStoresListKeysNextOptionalParams
extends coreClient.OperationOptions {
/** A skip token is used to continue retrieving items after an operation returns a partial result. If a previous response contains a nextLink element, the value of the nextLink element will include a skipToken parameter that specifies a starting point to use for subsequent calls. */
skipToken?: string;
}
extends coreClient.OperationOptions {}

/** Contains response data for the listKeysNext operation. */
export type ConfigurationStoresListKeysNextResponse = ApiKeyListResult;
Expand Down Expand Up @@ -943,10 +934,7 @@ export type OperationsRegionalCheckNameAvailabilityResponse = NameAvailabilitySt

/** Optional parameters. */
export interface OperationsListNextOptionalParams
extends coreClient.OperationOptions {
/** A skip token is used to continue retrieving items after an operation returns a partial result. If a previous response contains a nextLink element, the value of the nextLink element will include a skipToken parameter that specifies a starting point to use for subsequent calls. */
skipToken?: string;
}
extends coreClient.OperationOptions {}

/** Contains response data for the listNext operation. */
export type OperationsListNextResponse = OperationDefinitionListResult;
Expand Down Expand Up @@ -1014,16 +1002,6 @@ export interface PrivateLinkResourcesListByConfigurationStoreNextOptionalParams
/** Contains response data for the listByConfigurationStoreNext operation. */
export type PrivateLinkResourcesListByConfigurationStoreNextResponse = PrivateLinkResourceListResult;

/** Optional parameters. */
export interface KeyValuesListByConfigurationStoreOptionalParams
extends coreClient.OperationOptions {
/** A skip token is used to continue retrieving items after an operation returns a partial result. If a previous response contains a nextLink element, the value of the nextLink element will include a skipToken parameter that specifies a starting point to use for subsequent calls. */
skipToken?: string;
}

/** Contains response data for the listByConfigurationStore operation. */
export type KeyValuesListByConfigurationStoreResponse = KeyValueListResult;

/** Optional parameters. */
export interface KeyValuesGetOptionalParams
extends coreClient.OperationOptions {}
Expand All @@ -1050,16 +1028,6 @@ export interface KeyValuesDeleteOptionalParams
resumeFrom?: string;
}

/** Optional parameters. */
export interface KeyValuesListByConfigurationStoreNextOptionalParams
extends coreClient.OperationOptions {
/** A skip token is used to continue retrieving items after an operation returns a partial result. If a previous response contains a nextLink element, the value of the nextLink element will include a skipToken parameter that specifies a starting point to use for subsequent calls. */
skipToken?: string;
}

/** Contains response data for the listByConfigurationStoreNext operation. */
export type KeyValuesListByConfigurationStoreNextResponse = KeyValueListResult;

/** Optional parameters. */
export interface AppConfigurationManagementClientOptionalParams
extends coreClient.ServiceClientOptions {
Expand Down
54 changes: 27 additions & 27 deletions sdk/appconfiguration/arm-appconfiguration/src/models/mappers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1027,33 +1027,6 @@ export const PrivateLinkResource: coreClient.CompositeMapper = {
}
};

export const KeyValueListResult: coreClient.CompositeMapper = {
type: {
name: "Composite",
className: "KeyValueListResult",
modelProperties: {
value: {
serializedName: "value",
type: {
name: "Sequence",
element: {
type: {
name: "Composite",
className: "KeyValue"
}
}
}
},
nextLink: {
serializedName: "nextLink",
type: {
name: "String"
}
}
}
}
};

export const KeyValue: coreClient.CompositeMapper = {
type: {
name: "Composite",
Expand Down Expand Up @@ -1238,6 +1211,33 @@ export const DeletedConfigurationStore: coreClient.CompositeMapper = {
}
};

export const KeyValueListResult: coreClient.CompositeMapper = {
type: {
name: "Composite",
className: "KeyValueListResult",
modelProperties: {
value: {
serializedName: "value",
type: {
name: "Sequence",
element: {
type: {
name: "Composite",
className: "KeyValue"
}
}
}
},
nextLink: {
serializedName: "nextLink",
type: {
name: "String"
}
}
}
}
};

export const TrackedResource: coreClient.CompositeMapper = {
type: {
name: "Composite",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1128,7 +1128,6 @@ const listNextOperationSpec: coreClient.OperationSpec = {
bodyMapper: Mappers.ErrorResponse
}
},
queryParameters: [Parameters.apiVersion, Parameters.skipToken],
urlParameters: [
Parameters.$host,
Parameters.subscriptionId,
Expand All @@ -1148,7 +1147,6 @@ const listByResourceGroupNextOperationSpec: coreClient.OperationSpec = {
bodyMapper: Mappers.ErrorResponse
}
},
queryParameters: [Parameters.apiVersion, Parameters.skipToken],
urlParameters: [
Parameters.$host,
Parameters.subscriptionId,
Expand All @@ -1169,7 +1167,6 @@ const listKeysNextOperationSpec: coreClient.OperationSpec = {
bodyMapper: Mappers.ErrorResponse
}
},
queryParameters: [Parameters.apiVersion, Parameters.skipToken],
urlParameters: [
Parameters.$host,
Parameters.subscriptionId,
Expand All @@ -1191,7 +1188,6 @@ const listDeletedNextOperationSpec: coreClient.OperationSpec = {
bodyMapper: Mappers.ErrorResponse
}
},
queryParameters: [Parameters.apiVersion],
urlParameters: [
Parameters.$host,
Parameters.subscriptionId,
Expand Down
Loading

0 comments on commit d63d077

Please sign in to comment.