Skip to content

Commit

Permalink
[keyvault] Add support for 7.4 API version (Azure#25123)
Browse files Browse the repository at this point in the history
  • Loading branch information
timovv authored Mar 9, 2023
1 parent 51fd4ab commit 1cca1f1
Show file tree
Hide file tree
Showing 42 changed files with 127 additions and 132 deletions.
6 changes: 5 additions & 1 deletion sdk/keyvault/keyvault-admin/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
# Release History

## 4.4.0-beta.2 (Unreleased)
## 4.4.0 (Unreleased)

### Features Added

- Added `KeyVaultSettingsClient` to get and update Managed HSM settings.

### Breaking Changes

### Bugs Fixed

### Other Changes

- `KeyVaultAccessControlClient`, `KeyVaultBackupClient`, and `KeyVaultSettingsClient` now support service version 7.4 by default.

## 4.4.0-beta.1 (2022-11-10)

### Features Added
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-admin/assets.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "js",
"TagPrefix": "js/keyvault/keyvault-admin",
"Tag": "js/keyvault/keyvault-admin_6f3115fff2"
"Tag": "js/keyvault/keyvault-admin_f36e9a0ef6"
}
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-admin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@azure/keyvault-admin",
"sdk-type": "client",
"author": "Microsoft Corporation",
"version": "4.4.0-beta.2",
"version": "4.4.0",
"license": "MIT",
"description": "Isomorphic client library for Azure KeyVault's administrative functions.",
"homepage": "https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/keyvault/keyvault-admin/README.md",
Expand Down
4 changes: 2 additions & 2 deletions sdk/keyvault/keyvault-admin/review/keyvault-admin.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ export enum KnownKeyVaultRoleScope {
}

// @public
export const LATEST_API_VERSION = "7.4-preview.1";
export const LATEST_API_VERSION = "7.4";

// @public
export interface ListRoleAssignmentsOptions extends OperationOptions {
Expand Down Expand Up @@ -286,7 +286,7 @@ export interface SettingsClientOptions extends CommonClientOptions {
}

// @public
export type SUPPORTED_API_VERSIONS = "7.2" | "7.3" | "7.4-preview.1";
export type SUPPORTED_API_VERSIONS = "7.2" | "7.3" | "7.4";

// @public
export interface UnknownKeyVaultSetting extends KeyVaultSettingCommon {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"compilerOptions": {
"target": "ES2018",
"target": "ES2020",
"module": "commonjs",
"moduleResolution": "node",
"resolveJsonModule": true,
Expand Down
6 changes: 3 additions & 3 deletions sdk/keyvault/keyvault-admin/src/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@
/**
* Current version of the Key Vault Admin SDK.
*/
export const SDK_VERSION: string = "4.4.0-beta.2";
export const SDK_VERSION: string = "4.4.0";

/**
* The latest supported Key Vault service API version.
*/
export const LATEST_API_VERSION = "7.4-preview.1";
export const LATEST_API_VERSION = "7.4";

/**
* Supported API versions
*/
export type SUPPORTED_API_VERSIONS = "7.2" | "7.3" | "7.4-preview.1";
export type SUPPORTED_API_VERSIONS = "7.2" | "7.3" | "7.4";
4 changes: 2 additions & 2 deletions sdk/keyvault/keyvault-admin/src/generated/keyVaultClient.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions sdk/keyvault/keyvault-admin/src/generated/models/index.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 4 additions & 16 deletions sdk/keyvault/keyvault-admin/swagger/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ generate-metadata: false
add-credentials: false
license-header: MICROSOFT_MIT_NO_VERSION
input-file:
- https://raw.githubusercontent.com/Azure/azure-rest-api-specs/d78681a9d322bbd8d33ecaad7e6aaa2d513513b4/specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.4-preview.1/rbac.json
- https://raw.githubusercontent.com/Azure/azure-rest-api-specs/d78681a9d322bbd8d33ecaad7e6aaa2d513513b4/specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.4-preview.1/backuprestore.json
- https://raw.githubusercontent.com/Azure/azure-rest-api-specs/d78681a9d322bbd8d33ecaad7e6aaa2d513513b4/specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.4-preview.1/settings.json
- https://raw.githubusercontent.com/Azure/azure-rest-api-specs/551275acb80e1f8b39036b79dfc35a8f63b601a7/specification/keyvault/data-plane/Microsoft.KeyVault/stable/7.4/rbac.json
- https://raw.githubusercontent.com/Azure/azure-rest-api-specs/551275acb80e1f8b39036b79dfc35a8f63b601a7/specification/keyvault/data-plane/Microsoft.KeyVault/stable/7.4/backuprestore.json
- https://raw.githubusercontent.com/Azure/azure-rest-api-specs/551275acb80e1f8b39036b79dfc35a8f63b601a7/specification/keyvault/data-plane/Microsoft.KeyVault/stable/7.4/settings.json
output-folder: ../
source-code-folder-path: ./src/generated
package-version: 4.4.0-beta.2
package-version: 4.4.0
use-extension:
"@autorest/typescript": "6.0.0-beta.15"
```
Expand Down Expand Up @@ -79,15 +79,3 @@ directive:
from: GetSettingValue
to: GetSetting
```
### Fix listSettings response based on actual response
See https://github.com/Azure/azure-rest-api-specs/issues/21334
```yaml
directive:
- where-model: SettingsListResult
rename-property:
from: value
to: settings
```
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { KeyVaultSettingsClient } from "../../src/settingsClient";
import { authenticate } from "./utils/authentication";
import { getServiceVersion, onVersions } from "./utils/common";

onVersions({ minVer: "7.4-preview.1" }).describe("KeyVaultSettingsClient", () => {
onVersions({ minVer: "7.4" }).describe("KeyVaultSettingsClient", () => {
let client: KeyVaultSettingsClient;
let recorder: Recorder;

Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-admin/test/public/utils/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export function getSasToken() {
/**
* The known API versions that we support.
*/
export const serviceVersions = ["7.2", "7.3", "7.4-preview.1"] as const;
export const serviceVersions = ["7.2", "7.3", "7.4"] as const;

/**
* Fetches the service version to test against. This version could be configured as part of CI
Expand Down
4 changes: 2 additions & 2 deletions sdk/keyvault/keyvault-certificates/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Release History

## 4.7.0-beta.1 (Unreleased)
## 4.7.0 (Unreleased)

### Features Added

Expand All @@ -10,7 +10,7 @@

### Other Changes

- Updated `CertificateClient` to support service version 7.4-preview.1 by default.
- Updated `CertificateClient` to support service version 7.4 by default.

## 4.6.0 (2022-09-20)

Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-certificates/assets.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "js",
"TagPrefix": "js/keyvault/keyvault-certificates",
"Tag": "js/keyvault/keyvault-certificates_98ccd3fc69"
"Tag": "js/keyvault/keyvault-certificates_43821e21b3"
}
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-certificates/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@azure/keyvault-certificates",
"sdk-type": "client",
"author": "Microsoft Corporation",
"version": "4.7.0-beta.1",
"version": "4.7.0",
"license": "MIT",
"description": "Isomorphic client library for Azure KeyVault's certificates.",
"homepage": "https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/keyvault/keyvault-certificates/README.md",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export class CertificateClient {
// @public
export interface CertificateClientOptions extends ExtendedCommonClientOptions {
disableChallengeResourceVerification?: boolean;
serviceVersion?: "7.0" | "7.1" | "7.2" | "7.3" | "7.4-preview.1";
serviceVersion?: "7.0" | "7.1" | "7.2" | "7.3" | "7.4";
}

// @public
Expand Down
4 changes: 2 additions & 2 deletions sdk/keyvault/keyvault-certificates/src/certificatesModels.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
/**
* The latest supported KeyVault service API version
*/
export const LATEST_API_VERSION = "7.4-preview.1";
export const LATEST_API_VERSION = "7.4";

/**
* The optional parameters accepted by the KeyVault's CertificateClient
Expand All @@ -24,7 +24,7 @@ export interface CertificateClientOptions extends ExtendedCommonClientOptions {
/**
* The accepted versions of the KeyVault's service API.
*/
serviceVersion?: "7.0" | "7.1" | "7.2" | "7.3" | "7.4-preview.1";
serviceVersion?: "7.0" | "7.1" | "7.2" | "7.3" | "7.4";

/**
* Whether to disable verification that the authentication challenge resource matches the Key Vault domain.
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-certificates/src/constants.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.

export const SDK_VERSION: string = "4.7.0-beta.1";
export const SDK_VERSION: string = "4.7.0";

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 12 additions & 18 deletions sdk/keyvault/keyvault-certificates/src/generated/models/index.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 1cca1f1

Please sign in to comment.