Skip to content

Commit

Permalink
Revert "Upadte NewtonSoft.Json to 13.0.1 (Azure#18997)" (Azure#19168)
Browse files Browse the repository at this point in the history
This reverts commit 7eb9625.
  • Loading branch information
wyunchi-ms authored Aug 8, 2022
1 parent eafad56 commit a389635
Show file tree
Hide file tree
Showing 11 changed files with 24 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@
<PackageReference Include="Microsoft.Azure.Management.DeviceProvisioningServices" Version="0.10.0-preview" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="Newtonsoft.Json" Version="12.0.3" />
</ItemGroup>

<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory).., build.proj))\src\Az.Post.props" />

</Project>
4 changes: 4 additions & 0 deletions src/IotHub/IotHub/IotHub.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="2.2.0" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="Newtonsoft.Json" Version="12.0.3" />
</ItemGroup>

<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory).., build.proj))\src\Az.Post.props" />

</Project>
6 changes: 2 additions & 4 deletions src/Resources/ResourceManager/Extensions/JsonExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ namespace Microsoft.Azure.Commands.ResourceManager.Cmdlets.Extensions
using Newtonsoft.Json;
using Newtonsoft.Json.Converters;
using Newtonsoft.Json.Linq;
using Newtonsoft.Json.Serialization;

using System;
using System.Collections;
using System.Collections.Generic;
Expand Down Expand Up @@ -51,7 +49,7 @@ public static class JsonExtensions
Converters = new List<JsonConverter>
{
new TimeSpanConverter(),
new StringEnumConverter(new DefaultNamingStrategy()),
new StringEnumConverter { CamelCaseText = false },
new IsoDateTimeConverter { DateTimeStyles = DateTimeStyles.AdjustToUniversal },
},
};
Expand All @@ -69,7 +67,7 @@ public static class JsonExtensions
Converters = new List<JsonConverter>
{
new TimeSpanConverter(),
new StringEnumConverter(new DefaultNamingStrategy()),
new StringEnumConverter { CamelCaseText = false },
new IsoDateTimeConverter { DateTimeStyles = DateTimeStyles.AdjustToUniversal },
},
};
Expand Down
4 changes: 4 additions & 0 deletions src/Sql/Sql.LegacySdk/Sql.LegacySdk.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
<RootNamespace>Microsoft.Azure.Management.$(PsModuleName).Legacy</RootNamespace>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="10.0.3" PrivateAssets="all" />
</ItemGroup>

<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory).., build.proj))\src\Az.Post.props" />

</Project>
4 changes: 4 additions & 0 deletions src/Websites/Websites.Helper/Websites.Helper.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
<RootNamespace>Microsoft.Azure.PowerShell.Cmdlets.Websites.Helper</RootNamespace>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="10.0.3" />
</ItemGroup>

<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory).., build.proj))\src\Az.Post.props" />

</Project>
Binary file modified src/lib/NetFxPreloadAssemblies/Newtonsoft.Json.dll
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="Newtonsoft.Json" version="13.0.1" targetFramework="net452" />
<package id="Newtonsoft.Json" version="10.0.3" targetFramework="net452" />
</packages>
4 changes: 2 additions & 2 deletions tools/Common.Netcore.Dependencies.Test.targets
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<PackageReference Include="xunit.runner.console" Version="2.4.0" />
<PackageReference Include="System.Reflection.TypeExtensions" Version="4.5.0" />
<Reference Include="System.Net.Http" />
<PackageReference Include="Newtonsoft.Json" version="13.0.1" />
<PackageReference Include="Newtonsoft.Json" version="10.0.3" />
<PackageReference Include="Microsoft.Extensions.Primitives" Version="2.2.0" />
</ItemGroup>

Expand All @@ -34,7 +34,7 @@
<ItemGroup Condition="'$(TargetFramework)' == 'netcoreapp3.1'">
<!-- version of SDK should reference https://docs.microsoft.com/en-us/powershell/azure/what-is-azure-powershell -->
<PackageReference Include="Microsoft.PowerShell.SDK" Version="6.2.4" IncludeAssets="All" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.0" />
</ItemGroup>

Expand Down
3 changes: 1 addition & 2 deletions tools/Common.Netcore.Dependencies.targets
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
<PackageReference Include="Microsoft.Azure.PowerShell.Strategies" Version="1.3.59-preview"/>
<PackageReference Include="Microsoft.Azure.PowerShell.Clients.Websites" Version="1.3.59-preview"/>
<PackageReference Include="Microsoft.Azure.PowerShell.Common.Share" Version="1.3.59-preview"/>
<PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Azure.Core" Version="1.24.0"/>
Expand All @@ -40,6 +39,6 @@
<StorageToolsPath>$(NugetPackageRoot)\microsoft.azure.powershell.storage\1.3.59-preview\tools\</StorageToolsPath>
</PropertyGroup>
<ItemGroup Condition="'$(OmitJsonPackage)' != 'true'">
<PackageReference Include="Newtonsoft.Json" Version="13.0.1"/>
<PackageReference Include="Newtonsoft.Json" Version="10.0.3"/>
</ItemGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<PackageReference Include="Newtonsoft.Json" Version="10.0.3" />
<PackageReference Include="System.ValueTuple" Version="4.5.0-preview1-26216-02" />
</ItemGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<PackageReference Include="Newtonsoft.Json" Version="10.0.3" />
<PackageReference Include="System.ValueTuple" Version="4.5.0-preview1-26216-02" />
</ItemGroup>

Expand Down

0 comments on commit a389635

Please sign in to comment.