Merge pull request #1813 from aztfmod/akv-vmext

Fix KeyVault Windows VM Extension
aztfmod · Oct 6, 2023 · d5e4da5 · d5e4da5
2 parents 3892885 + da71538
commit d5e4da5
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 12 deletions.
diff --git a/.github/workflows/landingzone-scenarios.yaml b/.github/workflows/landingzone-scenarios.yaml
@@ -86,7 +86,7 @@ jobs:
     needs: [job]
 
     container:
-      image: aztfmod/rover:1.5.6-2309.0507
+      image: aztfmod/rover:1.5.7-2310.0211
       options: --user 0
 
     steps:

diff --git a/.github/workflows/rover.yaml b/.github/workflows/rover.yaml
@@ -46,7 +46,7 @@ jobs:
     needs: rover_setup
 
     container:
-      image: aztfmod/rover:1.5.6-2309.0507
+      image: aztfmod/rover:1.5.7-2310.0211
       options: --user 0
 
     env:

diff --git a/.github/workflows/standalone-compute.yaml b/.github/workflows/standalone-compute.yaml
@@ -46,7 +46,7 @@ jobs:
       matrix: ${{fromJSON(needs.load_scenarios.outputs.matrix)}}
 
     container:
-      image: aztfmod/rover:1.5.6-2309.0507
+      image: aztfmod/rover:1.5.7-2310.0211
       options: --user 0
 
     steps:
@@ -131,7 +131,7 @@ jobs:
     needs: [testcases]
 
     container:
-      image: aztfmod/rover:1.5.6-2309.0507
+      image: aztfmod/rover:1.5.7-2310.0211
       options: --user 0
 
     steps:

diff --git a/.github/workflows/standalone-networking.yaml b/.github/workflows/standalone-networking.yaml
@@ -46,7 +46,7 @@ jobs:
       matrix: ${{fromJSON(needs.load_scenarios.outputs.matrix)}}
 
     container:
-      image: aztfmod/rover:1.5.6-2309.0507
+      image: aztfmod/rover:1.5.7-2310.0211
       options: --user 0
 
     steps:
@@ -131,7 +131,7 @@ jobs:
     needs: [testcases]
 
     container:
-      image: aztfmod/rover:1.5.6-2309.0507
+      image: aztfmod/rover:1.5.7-2310.0211
       options: --user 0
 
     steps:

diff --git a/.github/workflows/standalone-regressor-tf100.yaml b/.github/workflows/standalone-regressor-tf100.yaml
@@ -58,7 +58,7 @@ jobs:
       matrix: ${{fromJSON(needs.load_scenarios.outputs.matrix)}}
 
     container:
-      image: aztfmod/rover:1.5.6-2309.0507
+      image: aztfmod/rover:1.5.7-2310.0211
       options: --user 0
 
     steps:
@@ -178,7 +178,7 @@ jobs:
     needs: [testcases]
 
     container:
-      image: aztfmod/rover:1.5.6-2309.0507
+      image: aztfmod/rover:1.5.7-2310.0211
       options: --user 0
 
     steps:

diff --git a/.github/workflows/standalone-tf100.yaml b/.github/workflows/standalone-tf100.yaml
@@ -55,7 +55,7 @@ jobs:
       matrix: ${{fromJSON(needs.load_scenarios.outputs.matrix)}}
 
     container:
-      image: aztfmod/rover:1.5.6-2309.0507
+      image: aztfmod/rover:1.5.7-2310.0211
       options: --user 0
 
     steps:
@@ -140,7 +140,7 @@ jobs:
     needs: [testcases]
 
     container:
-      image: aztfmod/rover:1.5.6-2309.0507
+      image: aztfmod/rover:1.5.7-2310.0211
       options: --user 0
 
     steps:

diff --git a/compute_virtual_machines_extensions.tf b/compute_virtual_machines_extensions.tf
@@ -105,7 +105,8 @@ module "vm_extension_generic" {
 }
 
 module "keyvault_for_windows" {
-  source = "./modules/compute/virtual_machine_extensions"
+  source     = "./modules/compute/virtual_machine_extensions"
+  depends_on = [module.keyvault_certificates]
 
   for_each = {
     for key, value in try(local.compute.virtual_machines, {}) : key => value

diff --git a/rover_on_ssh_host.yml b/rover_on_ssh_host.yml
@@ -11,7 +11,7 @@
 version: '3.7'
 services:
   rover:
-    image: aztfmod/rover:1.5.6-2309.0507
+    image: aztfmod/rover:1.5.7-2310.0211
 
     user: vscode