Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use project manila share user from Azimuth #17

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

sjpb
Copy link
Contributor

@sjpb sjpb commented Feb 13, 2024

Changes project manila shares to use the share user provided by Azimuth (in https://github.com/stackhpc/azimuth/pull/148/files), rather assuming there is only a single access rule. Fixes cases where multiple access rules are defined on the project share.

workstation.yml Outdated Show resolved Hide resolved
workstation.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@JohnGarbutt JohnGarbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjpb I am happy with this now if you are.

@m-bull m-bull self-requested a review February 20, 2024 10:01
Copy link
Collaborator

@mkjpryor mkjpryor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkjpryor mkjpryor merged commit 949e28c into main Feb 20, 2024
@JohnGarbutt JohnGarbutt added the bug Something isn't working label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants