-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto create project manila cephfs shares #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still also unconvinced about gating this on the create_manila_project_share
boolean.
Don't we want it to be done whenever Manila with the Ceph driver is available?
No, because of the networking requirements. It only works when the networks are setup "correctly". Thinking about that... I probably need to simply not create a share in the case where we can't find a valid share type, as that is the way a project being setup for manila can be checked on Arcus, and its a good solution I think. |
Needs a quick final test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds a new helm chart option, that defaults to False:
provider.openstack.createManilaProjectShare
When Manila is present, and you enable this option,
Azimuth we auto create a project manila share
and that known to all appliances via some extra vars