Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto create project manila cephfs shares #148

Merged
merged 21 commits into from
Jan 31, 2024

Conversation

JohnGarbutt
Copy link
Contributor

@JohnGarbutt JohnGarbutt commented Jan 18, 2024

Adds a new helm chart option, that defaults to False:
provider.openstack.createManilaProjectShare

When Manila is present, and you enable this option,
Azimuth we auto create a project manila share
and that known to all appliances via some extra vars

@JohnGarbutt JohnGarbutt changed the title WIP: Adding auto creation of manila share Adding auto creation of manila share Jan 23, 2024
@JohnGarbutt JohnGarbutt marked this pull request as ready for review January 23, 2024 19:00
@JohnGarbutt JohnGarbutt requested a review from a team as a code owner January 23, 2024 19:00
@JohnGarbutt JohnGarbutt requested review from mkjpryor and sjpb January 23, 2024 19:00
@JohnGarbutt JohnGarbutt changed the title Adding auto creation of manila share Option to auto create project manila cephfs shares Jan 23, 2024
@JohnGarbutt JohnGarbutt changed the title Option to auto create project manila cephfs shares Auto create project manila cephfs shares Jan 23, 2024
Copy link
Collaborator

@mkjpryor mkjpryor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still also unconvinced about gating this on the create_manila_project_share boolean.

Don't we want it to be done whenever Manila with the Ceph driver is available?

api/azimuth/provider/openstack/api/shares.py Outdated Show resolved Hide resolved
api/azimuth/provider/openstack/api/core.py Outdated Show resolved Hide resolved
api/azimuth/provider/openstack/api/shares.py Outdated Show resolved Hide resolved
api/azimuth/provider/openstack/provider.py Outdated Show resolved Hide resolved
api/azimuth/provider/openstack/provider.py Outdated Show resolved Hide resolved
api/azimuth/provider/openstack/provider.py Outdated Show resolved Hide resolved
api/azimuth/provider/openstack/provider.py Outdated Show resolved Hide resolved
api/azimuth/provider/openstack/provider.py Outdated Show resolved Hide resolved
@JohnGarbutt
Copy link
Contributor Author

JohnGarbutt commented Jan 24, 2024

Don't we want it to be done whenever Manila with the Ceph driver is available?

No, because of the networking requirements. It only works when the networks are setup "correctly".

Thinking about that... I probably need to simply not create a share in the case where we can't find a valid share type, as that is the way a project being setup for manila can be checked on Arcus, and its a good solution I think.

@mkjpryor mkjpryor added the enhancement New feature or request label Jan 25, 2024
@JohnGarbutt JohnGarbutt requested review from mkjpryor and sjpb January 29, 2024 12:49
api/azimuth/provider/openstack/provider.py Outdated Show resolved Hide resolved
api/azimuth/provider/openstack/provider.py Outdated Show resolved Hide resolved
@JohnGarbutt JohnGarbutt requested a review from mkjpryor January 29, 2024 14:31
@JohnGarbutt
Copy link
Contributor Author

Needs a quick final test.

Copy link
Collaborator

@mkjpryor mkjpryor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnGarbutt JohnGarbutt merged commit 3d051f5 into master Jan 31, 2024
5 of 6 checks passed
@JohnGarbutt JohnGarbutt deleted the feature/create-manila-project-share branch January 31, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants