Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Replayed games counting as a loss #27

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Fix: Replayed games counting as a loss #27

merged 1 commit into from
Nov 12, 2024

Conversation

laasker
Copy link
Collaborator

@laasker laasker commented Nov 12, 2024 •
edited
Loading

Changes Proposed:

  • Replayed games no longer decreases rating/counts as a loss

Issues Addressed:

SOURCE:

Tests Performed:

  • I replayed a solo 3v3 game that i previous played and left the replay and checked that it no longer reduces my solo team rating

How to Test the Changes:

  1. Must have https://github.com/azerothcore/mod-arena-replay
  2. Play a solo 3v3 game
  3. Check the amount of rating/games played (either through database or statistics through solo 3v3 npc)
  4. Go to the Replay Arena NPC and watch a replay of a solo 3v3 game.
  5. While on the replay, click to leave the match (on the mini-map button)
  6. See that the rating and amount of games are still the same as before

@Helias Helias merged commit d4ad940 into azerothcore:master Nov 12, 2024
1 check passed
@laasker laasker deleted the fix-Replay-counting-as-loss branch November 16, 2024 23:03
@Helias Helias mentioned this pull request Nov 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laasker @Helias